Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1414003

Re: [PATCH] net: ethernet: cavium: liquidio: request_manager: Remove create_workqueue

From Tejun Heo <tj@kernel.org>
Newsgroups linux.kernel
Subject Re: [PATCH] net: ethernet: cavium: liquidio: request_manager: Remove create_workqueue
Date 2016-06-05 12:30 +0200
Message-ID <rGDtH-5uK-97@gated-at.bofh.it> (permalink)
References <rGlGq-2OD-19@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Sat, Jun 04, 2016 at 08:54:00PM +0530, Bhaktipriya Shridhar wrote:
> diff --git a/drivers/net/ethernet/cavium/liquidio/request_manager.c b/drivers/net/ethernet/cavium/liquidio/request_manager.c
> index a2a2465..9313915 100644
> --- a/drivers/net/ethernet/cavium/liquidio/request_manager.c
> +++ b/drivers/net/ethernet/cavium/liquidio/request_manager.c
> @@ -144,7 +144,9 @@ int octeon_init_instr_queue(struct octeon_device *oct,
> 
>  	oct->fn_list.setup_iq_regs(oct, iq_no);
> 
> -	oct->check_db_wq[iq_no].wq = create_workqueue("check_iq_db");
> +	oct->check_db_wq[iq_no].wq = alloc_workqueue("check_iq_db",
> +						     WQ_MEM_RECLAIM,
> +						     0);

Why the new line between WQ_MEM_RECLAIM and 0?

Except for the subj tag and the above nit,

 Acked-by: Tejun Heo <tj@kernel.org>

Thanks.

-- 
tejun

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH] net: ethernet: cavium: liquidio: request_manager: Remove  create_workqueue Bhaktipriya Shridhar <bhaktipriya96@gmail.com> - 2016-06-04 17:30 +0200
  Re: [PATCH] net: ethernet: cavium: liquidio: request_manager: Remove  create_workqueue Tejun Heo <tj@kernel.org> - 2016-06-05 12:30 +0200
  Re: [PATCH] net: ethernet: cavium: liquidio: request_manager:  Remove create_workqueue David Miller <davem@davemloft.net> - 2016-06-07 03:20 +0200

csiph-web