Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1418058

RE: [PATCH] x86/microcode/intel: Quieten down microcode updates on large systems

Show all headers | View raw

> -----Original Message-----
> From: linux-kernel-owner@vger.kernel.org [mailto:linux-kernel-
> owner@vger.kernel.org] On Behalf Of Andi Kleen
> Sent: Tuesday, May 31, 2016 4:23 PM
> To: x86@kernel.org
> Cc: linux-kernel@vger.kernel.org; Andi Kleen <ak@linux.intel.com>
> Subject: [PATCH] x86/microcode/intel: Quieten down microcode updates
> on large systems
...
> diff --git a/arch/x86/kernel/cpu/microcode/intel.c
> @@ -808,8 +809,14 @@ static int collect_cpu_info(int cpu_num, struct
> cpu_signature *csig)
>  	}
> 
>  	csig->rev = c->microcode;
> -	pr_info("CPU%d sig=0x%x, pf=0x%x, revision=0x%x\n",
> -		cpu_num, csig->sig, csig->pf, csig->rev);
> +
> +	/* No extra locking on prev, races are harmless. */
> +	if (csig->sig != prev.sig || csig->pf != prev.pf ||
> +	    csig->rev != prev.rev) {
> +		pr_info("CPU sig=0x%x, pf=0x%x, revision=0x%x\n",
> +			csig->sig, csig->pf, csig->rev);
> +		prev = *csig;
> +	}
...
> -	pr_info("CPU%d updated to revision 0x%x, date = %04x-%02x-
> %02x\n",
> -		cpu, val[1],
> -		mc->hdr.date & 0xffff,
> -		mc->hdr.date >> 24,
> -		(mc->hdr.date >> 16) & 0xff);
> +	if (val[1] != prev_rev) {
> +		pr_info("CPU updated to revision 0x%x, date = %04x-%02x-
> %02x\n",

"CPU(s)" would help convey that the messages now apply to one or 
more CPUs.

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] x86/microcode/intel: Quieten down microcode updates on large systems Andi Kleen <andi@firstfloor.org> - 2016-06-01 06:40 +0200
  RE: [PATCH] x86/microcode/intel: Quieten down microcode updates on  large systems "Elliott, Robert (Persistent Memory)" <elliott@hpe.com> - 2016-06-09 06:40 +0200
    Re: [PATCH] x86/microcode/intel: Quieten down microcode updates on  large systems Henrique de Moraes Holschuh <hmh@hmh.eng.br> - 2016-06-09 17:50 +0200

csiph-web