Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1417988
| From | Vivien Didelot <vivien.didelot@savoirfairelinux.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | [PATCH net-next 2/8] net: dsa: mv88e6xxx: remove redundant assignments |
| Date | 2016-06-09 02:50 +0200 |
| Message-ID | <rHWkx-7lM-13@gated-at.bofh.it> (permalink) |
| References | <rHWkx-7lM-1@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
The chip->ds and ds->slave_mii_bus assignments are common to both legacy and new MDIO probing and are already done in the later setup code. Remove the duplicated assignments from the MDIO probing code. Signed-off-by: Vivien Didelot <vivien.didelot@savoirfairelinux.com> --- drivers/net/dsa/mv88e6xxx.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/net/dsa/mv88e6xxx.c b/drivers/net/dsa/mv88e6xxx.c index 6a2528f..cb8b1b7 100644 --- a/drivers/net/dsa/mv88e6xxx.c +++ b/drivers/net/dsa/mv88e6xxx.c @@ -3706,7 +3706,6 @@ int mv88e6xxx_probe(struct mdio_device *mdiodev) ds->priv = ps; ds->dev = dev; ps->dev = dev; - ps->ds = ds; ps->bus = mdiodev->bus; ps->sw_addr = mdiodev->addr; mutex_init(&ps->smi_mutex); @@ -3746,8 +3745,6 @@ int mv88e6xxx_probe(struct mdio_device *mdiodev) if (err) return err; - ds->slave_mii_bus = ps->mdio_bus; - dev_set_drvdata(dev, ds); err = dsa_register_switch(ds, mdiodev->dev.of_node); -- 2.8.3
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH net-next 0/8] net: dsa: mv88e6xxx: misc probe improvements Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2016-06-09 02:50 +0200
[PATCH net-next 6/8] net: dsa: mv88e6xxx: add chip detection helper Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2016-06-09 02:50 +0200
[PATCH net-next 4/8] net: dsa: mv88e6xxx: do not increment bus refcount Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2016-06-09 02:50 +0200
Re: [PATCH net-next 4/8] net: dsa: mv88e6xxx: do not increment bus refcount Andrew Lunn <andrew@lunn.ch> - 2016-06-09 04:40 +0200
Re: [PATCH net-next 4/8] net: dsa: mv88e6xxx: do not increment bus refcount Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2016-06-10 22:00 +0200
Re: [PATCH net-next 4/8] net: dsa: mv88e6xxx: do not increment bus refcount Andrew Lunn <andrew@lunn.ch> - 2016-06-10 22:10 +0200
[PATCH net-next 2/8] net: dsa: mv88e6xxx: remove redundant assignments Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2016-06-09 02:50 +0200
Re: [PATCH net-next 2/8] net: dsa: mv88e6xxx: remove redundant assignments Andrew Lunn <andrew@lunn.ch> - 2016-06-09 04:40 +0200
[PATCH net-next 5/8] net: dsa: mv88e6xxx: add switch register helpers Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2016-06-09 02:50 +0200
Re: [PATCH net-next 5/8] net: dsa: mv88e6xxx: add switch register helpers Andrew Lunn <andrew@lunn.ch> - 2016-06-09 04:40 +0200
Re: [PATCH net-next 5/8] net: dsa: mv88e6xxx: add switch register helpers Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2016-06-09 15:00 +0200
[PATCH net-next 3/8] net: dsa: mv88e6xxx: use already declared variables Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2016-06-09 02:50 +0200
Re: [PATCH net-next 3/8] net: dsa: mv88e6xxx: use already declared variables Andrew Lunn <andrew@lunn.ch> - 2016-06-09 04:40 +0200
[PATCH net-next 8/8] net: dsa: mv88e6xxx: fail on mismatching probe Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2016-06-09 02:50 +0200
Re: [PATCH net-next 8/8] net: dsa: mv88e6xxx: fail on mismatching probe Andrew Lunn <andrew@lunn.ch> - 2016-06-09 04:30 +0200
Re: [PATCH net-next 8/8] net: dsa: mv88e6xxx: fail on mismatching probe Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2016-06-10 22:40 +0200
[PATCH net-next 7/8] net: dsa: mv88e6xxx: explicit compatible devices Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2016-06-09 02:50 +0200
Re: [PATCH net-next 7/8] net: dsa: mv88e6xxx: explicit compatible devices Andrew Lunn <andrew@lunn.ch> - 2016-06-09 04:20 +0200
Re: [PATCH net-next 7/8] net: dsa: mv88e6xxx: explicit compatible devices Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2016-06-10 22:30 +0200
[PATCH net-next 1/8] net: dsa: mv88e6xxx: fix style issues Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2016-06-09 02:50 +0200
Re: [PATCH net-next 1/8] net: dsa: mv88e6xxx: fix style issues Andrew Lunn <andrew@lunn.ch> - 2016-06-09 04:30 +0200
csiph-web