Re: [PATCH v3 1/2] usb: ohci-at91: Forcibly suspend ports while USB suspend

Path	csiph.com!aioe.org!gothmog.csi.it!bofh.it!news.nic.it!robomod
From	Alexandre Belloni <alexandre.belloni@free-electrons.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v3 1/2] usb: ohci-at91: Forcibly suspend ports while USB suspend
Date	Wed, 08 Jun 2016 22:40:01 +0200
Message-ID	<rHSqB-4VQ-3@gated-at.bofh.it> (permalink)
References	<rHDhT-3FX-3@gated-at.bofh.it> <rHDhT-3FX-1@gated-at.bofh.it> <rHSgV-4S1-13@gated-at.bofh.it>
MIME-Version	1.0
Content-Type	text/plain; charset=us-ascii
Content-Disposition	inline
User-Agent	Mutt/1.6.0 (2016-04-01)
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	51
Organization	linux.* mail to news gateway
X-Original-Cc	Wenyou Yang <wenyou.yang@atmel.com>, Alan Stern <stern@rowland.harvard.edu>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Nicolas Ferre <nicolas.ferre@atmel.com>, Pawel Moll <pawel.moll@arm.com>, Mark Brown <broonie@kernel.org>, Ian Campbell <ijc+devicetree@hellion.org.uk>, Kumar Gala <galak@codeaurora.org>, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-usb@vger.kernel.org
X-Original-Date	Wed, 8 Jun 2016 22:38:10 +0200
X-Original-Message-ID	<20160608203810.GF2466@piout.net>
X-Original-References	<1465359311-14544-1-git-send-email-wenyou.yang@atmel.com> <1465359311-14544-2-git-send-email-wenyou.yang@atmel.com> <20160608202651.GA23604@rob-hp-laptop>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1417853

Show key headers only | View raw

On 08/06/2016 at 15:26:51 -0500, Rob Herring wrote :
> On Wed, Jun 08, 2016 at 12:15:10PM +0800, Wenyou Yang wrote:
> > In order to the save power consumption, as a workaround, suspend
> > forcibly the USB PORTA/B/C via set the SUSPEND_A/B/C bits of OHCI
> > Interrupt Configuration Register in the SFRs while OHCI USB suspend.
> > 
> > This suspend operation must be done before the USB clock is disabled,
> > resume after the USB clock is enabled.
> > 
> > Signed-off-by: Wenyou Yang <wenyou.yang@atmel.com>
> > ---
> > 
> > Changes in v3:
> >  - Change the compatible description for more precise.
> > 
> > Changes in v2:
> >  - Add compatible to support forcibly suspend the ports.
> >  - Add soc/at91/at91_sfr.h to accommodate the defines.
> >  - Add error checking for .sfr_regmap.
> >  - Remove unnecessary regmap_read() statement.
> > 
> >  .../devicetree/bindings/usb/atmel-usb.txt          |  6 +-
> >  drivers/usb/host/ohci-at91.c                       | 80 +++++++++++++++++++++-
> >  include/soc/at91/at91_sfr.h                        | 29 ++++++++
> >  3 files changed, 112 insertions(+), 3 deletions(-)
> >  create mode 100644 include/soc/at91/at91_sfr.h
> > 
> > diff --git a/Documentation/devicetree/bindings/usb/atmel-usb.txt b/Documentation/devicetree/bindings/usb/atmel-usb.txt
> > index 5883b73..888deaa 100644
> > --- a/Documentation/devicetree/bindings/usb/atmel-usb.txt
> > +++ b/Documentation/devicetree/bindings/usb/atmel-usb.txt
> > @@ -3,8 +3,10 @@ Atmel SOC USB controllers
> >  OHCI
> >  
> >  Required properties:
> > - - compatible: Should be "atmel,at91rm9200-ohci" for USB controllers
> > -   used in host mode.
> > + - compatible: Should be one of the following
> > +	       "atmel,at91rm9200-ohci" for USB controllers used in host mode.
> > +	       "atmel,sama5d2-ohci" for USB controllers used in host mode
> > +	       on SAMA5D2 which can force to suspend.
> 
> Guess I wasn't clear enough before. Drop "which can force to suspend".
> 

Well, my point is that we don't need a new compatible anyway.

-- 
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v3 1/2] usb: ohci-at91: Forcibly suspend ports while USB suspend Wenyou Yang <wenyou.yang@atmel.com> - 2016-06-08 06:30 +0200
  Re: [PATCH v3 1/2] usb: ohci-at91: Forcibly suspend ports while USB  suspend Nicolas Ferre <nicolas.ferre@atmel.com> - 2016-06-08 12:10 +0200
    Re: [PATCH v3 1/2] usb: ohci-at91: Forcibly suspend ports while USB  suspend Nicolas Ferre <nicolas.ferre@atmel.com> - 2016-06-08 12:50 +0200
  Re: [PATCH v3 1/2] usb: ohci-at91: Forcibly suspend ports while USB  suspend Alan Stern <stern@rowland.harvard.edu> - 2016-06-08 21:20 +0200
    RE: [PATCH v3 1/2] usb: ohci-at91: Forcibly suspend ports while USB  suspend "Yang, Wenyou" <Wenyou.Yang@atmel.com> - 2016-06-10 11:00 +0200
  Re: [PATCH v3 1/2] usb: ohci-at91: Forcibly suspend ports while USB  suspend Rob Herring <robh@kernel.org> - 2016-06-08 22:30 +0200
    Re: [PATCH v3 1/2] usb: ohci-at91: Forcibly suspend ports while USB  suspend Alexandre Belloni <alexandre.belloni@free-electrons.com> - 2016-06-08 22:40 +0200

csiph-web