Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1417272

Re: [PATCH v3 1/2] usb: ohci-at91: Forcibly suspend ports while USB suspend

Show all headers | View raw

Le 08/06/2016 12:04, Nicolas Ferre a écrit :
> Le 08/06/2016 06:15, Wenyou Yang a écrit :
>> In order to the save power consumption, as a workaround, suspend
>> forcibly the USB PORTA/B/C via set the SUSPEND_A/B/C bits of OHCI
>> Interrupt Configuration Register in the SFRs while OHCI USB suspend.
>>
>> This suspend operation must be done before the USB clock is disabled,
>> resume after the USB clock is enabled.
>>
>> Signed-off-by: Wenyou Yang <wenyou.yang@atmel.com>
> 
> Little nitpicking below...
> 
>> ---
>>
>> Changes in v3:
>>  - Change the compatible description for more precise.
>>
>> Changes in v2:
>>  - Add compatible to support forcibly suspend the ports.
>>  - Add soc/at91/at91_sfr.h to accommodate the defines.
>>  - Add error checking for .sfr_regmap.
>>  - Remove unnecessary regmap_read() statement.
>>
>>  .../devicetree/bindings/usb/atmel-usb.txt          |  6 +-
>>  drivers/usb/host/ohci-at91.c                       | 80 +++++++++++++++++++++-
>>  include/soc/at91/at91_sfr.h                        | 29 ++++++++

Oops sorry, additional comment which is not nitpicking, this one:

We already have SFR header file in this patch:

Author: Cyrille Pitchen <cyrille.pitchen@atmel.com>
Date:   Thu Mar 17 17:04:00 2016 +0100

    ARM: dts: at91: sama5d2: add SFR node

    This SFR node is looked up by the I2S controller driver to tune the
    SFR_I2SCLKSEL register.

    Signed-off-by: Cyrille Pitchen <cyrille.pitchen@atmel.com>
    Signed-off-by: Ludovic Desroches <ludovic.desroches@atmel.com>
    Acked-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
    Acked-by: Rob Herring <robh@kernel.org>
    Signed-off-by: Nicolas Ferre <nicolas.ferre@atmel.com>

Which is already accepted by arm-soc guys for 4.7... So my ack
transforms into a nack, sorry...

We will have to coordinate the effort and maybe take the whole series
with us. But for sure, you'll have to use the existing
include/soc/at91/atmel-sfr.h file and build on top of it...

Bye,

>>  3 files changed, 112 insertions(+), 3 deletions(-)
>>  create mode 100644 include/soc/at91/at91_sfr.h

[..]

> 
> But you can take my:
> 
> Acked-by: Nicolas Ferre <nicolas.ferre@atmel.com>
> 
> with the little corrections listed.
> 
> Alan, We plan to take the second patch of this series with AT91 git tree
> through arm-soc. Do you agree to take this one through yours?

Alan, forget this request, we'll have to coordinate differently.

Sorry for the noise. Bye,
-- 
Nicolas Ferre

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v3 1/2] usb: ohci-at91: Forcibly suspend ports while USB suspend Wenyou Yang <wenyou.yang@atmel.com> - 2016-06-08 06:30 +0200
  Re: [PATCH v3 1/2] usb: ohci-at91: Forcibly suspend ports while USB  suspend Nicolas Ferre <nicolas.ferre@atmel.com> - 2016-06-08 12:10 +0200
    Re: [PATCH v3 1/2] usb: ohci-at91: Forcibly suspend ports while USB  suspend Nicolas Ferre <nicolas.ferre@atmel.com> - 2016-06-08 12:50 +0200
  Re: [PATCH v3 1/2] usb: ohci-at91: Forcibly suspend ports while USB  suspend Alan Stern <stern@rowland.harvard.edu> - 2016-06-08 21:20 +0200
    RE: [PATCH v3 1/2] usb: ohci-at91: Forcibly suspend ports while USB  suspend "Yang, Wenyou" <Wenyou.Yang@atmel.com> - 2016-06-10 11:00 +0200
  Re: [PATCH v3 1/2] usb: ohci-at91: Forcibly suspend ports while USB  suspend Rob Herring <robh@kernel.org> - 2016-06-08 22:30 +0200
    Re: [PATCH v3 1/2] usb: ohci-at91: Forcibly suspend ports while USB  suspend Alexandre Belloni <alexandre.belloni@free-electrons.com> - 2016-06-08 22:40 +0200

csiph-web