Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1417783
| Path | csiph.com!news.mixmin.net!news.unit0.net!news.panservice.it!bofh.it!news.nic.it!robomod |
|---|---|
| From | Alan Stern <stern@rowland.harvard.edu> |
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v3 1/2] usb: ohci-at91: Forcibly suspend ports while USB suspend |
| Date | Wed, 08 Jun 2016 21:20:01 +0200 |
| Message-ID | <rHRbb-4cI-3@gated-at.bofh.it> (permalink) |
| References | <rHDhT-3FX-1@gated-at.bofh.it> |
| X-X-Sender | stern@iolanthe.rowland.org |
| MIME-Version | 1.0 |
| Content-Type | TEXT/PLAIN; charset=US-ASCII |
| Sender | robomod@news.nic.it |
| List-ID | <linux-kernel.vger.kernel.org> |
| X-Mailing-List | linux-kernel@vger.kernel.org |
| Approved | robomod@news.nic.it |
| Lines | 22 |
| Organization | linux.* mail to news gateway |
| X-Original-Cc | Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Nicolas Ferre <nicolas.ferre@atmel.com>, Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>, Mark Brown <broonie@kernel.org>, Ian Campbell <ijc+devicetree@hellion.org.uk>, Kumar Gala <galak@codeaurora.org>, Alexandre Belloni <alexandre.belloni@free-electrons.com>, Kernel development list <linux-kernel@vger.kernel.org>, <devicetree@vger.kernel.org>, <linux-arm-kernel@lists.infradead.org>, USB list <linux-usb@vger.kernel.org> |
| X-Original-Date | Wed, 8 Jun 2016 15:13:56 -0400 (EDT) |
| X-Original-Message-ID | <Pine.LNX.4.44L0.1606081352250.2191-100000@iolanthe.rowland.org> |
| X-Original-References | <1465359311-14544-2-git-send-email-wenyou.yang@atmel.com> |
| X-Original-Sender | linux-kernel-owner@vger.kernel.org |
| Xref | csiph.com linux.kernel:1417783 |
Show key headers only | View raw
On Wed, 8 Jun 2016, Wenyou Yang wrote: > In order to the save power consumption, as a workaround, suspend > forcibly the USB PORTA/B/C via set the SUSPEND_A/B/C bits of OHCI > Interrupt Configuration Register in the SFRs while OHCI USB suspend. > > This suspend operation must be done before the USB clock is disabled, > resume after the USB clock is enabled. > > Signed-off-by: Wenyou Yang <wenyou.yang@atmel.com> > --- You never answered the questions I posted for the first version of this patch: What does this mean? What does suspending a port do? Is it the same as a normal USB port suspend? If it is the same, why doesn't the USB_PORT_FEAT_SUSPEND subcase of the SetPortFeature case in ohci_hub_control() already take care of this? Alan Stern
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH v3 1/2] usb: ohci-at91: Forcibly suspend ports while USB suspend Wenyou Yang <wenyou.yang@atmel.com> - 2016-06-08 06:30 +0200
Re: [PATCH v3 1/2] usb: ohci-at91: Forcibly suspend ports while USB suspend Nicolas Ferre <nicolas.ferre@atmel.com> - 2016-06-08 12:10 +0200
Re: [PATCH v3 1/2] usb: ohci-at91: Forcibly suspend ports while USB suspend Nicolas Ferre <nicolas.ferre@atmel.com> - 2016-06-08 12:50 +0200
Re: [PATCH v3 1/2] usb: ohci-at91: Forcibly suspend ports while USB suspend Alan Stern <stern@rowland.harvard.edu> - 2016-06-08 21:20 +0200
RE: [PATCH v3 1/2] usb: ohci-at91: Forcibly suspend ports while USB suspend "Yang, Wenyou" <Wenyou.Yang@atmel.com> - 2016-06-10 11:00 +0200
Re: [PATCH v3 1/2] usb: ohci-at91: Forcibly suspend ports while USB suspend Rob Herring <robh@kernel.org> - 2016-06-08 22:30 +0200
Re: [PATCH v3 1/2] usb: ohci-at91: Forcibly suspend ports while USB suspend Alexandre Belloni <alexandre.belloni@free-electrons.com> - 2016-06-08 22:40 +0200
csiph-web