Re: [PATCH] Add .set_antenna callback in ath6kl driver to remove wireless core warns

From	Ben Greear <greearb@candelatech.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] Add .set_antenna callback in ath6kl driver to remove wireless core warns
Date	2016-06-08 18:20 +0200
Message-ID	<rHOmZ-2r3-9@gated-at.bofh.it> (permalink)
References	(4 earlier) <rHNAB-1Ti-17@gated-at.bofh.it> <rHNKi-1Yh-33@gated-at.bofh.it> <rHNTY-21z-31@gated-at.bofh.it> <rHO3J-24Z-17@gated-at.bofh.it> <rHO3J-24Z-23@gated-at.bofh.it>
Organization	Candela Technologies

Show all headers | View raw

On 06/08/2016 08:56 AM, Prasun Maiti wrote:
> Please help me how to test this one?? It will be great to me if you help me.

I do not have time or interest, sorry.  You basically need access to
firmware source to do any useful development on this driver in my opinion,
and I do not have access to that source.

Why are you so concerned about the warning anyway?

Thanks,
Ben

>
> On Wed, Jun 8, 2016 at 9:21 PM, Ben Greear <greearb@candelatech.com> wrote:
>> On 06/08/2016 08:46 AM, Prasun Maiti wrote:
>>>
>>> Please tell me if I mention that this code is untested in commit log,
>>> then could you check the code kindly and also help me to fix this type
>>> of warning?
>>
>>
>> In my experience, ath6kl has very fragile and buggy firmware, so I would
>> not add any new API to it unless you have tested this thoroughly.
>>
>> Thanks,
>> Ben
>>
>>>
>>> On Wed, Jun 8, 2016 at 9:00 PM, Valo, Kalle <kvalo@qca.qualcomm.com>
>>> wrote:
>>>>
>>>> Prasun Maiti <prasunmaiti87@gmail.com> writes:
>>>>
>>>>> I am not sure it works fine. Like ath6kl driver send another cmd to
>>>>> firmare, I have just filled up the cmd buffer with "tx_ant", and
>>>>> "rx_ant" values, then use "ath6kl_wmi_cmd_send()" api to send the cmd
>>>>> buffer to firmware. I have resend the patch as there are some errors
>>>>> in the previous patch. Let me know if any modifications are needed?
>>>>
>>>>
>>>> I don't take untested code. In some special cases it might be ok to send
>>>> untested code but even then it needs to be clearly stated in the commit
>>>> log that it's untested.
>>>>
>>>> Please resend once you have tested this, I'm dropping this now.
>>>>
>>>> --
>>>> Kalle Valo
>>>
>>>
>>>
>>>
>>
>>
>> --
>> Ben Greear <greearb@candelatech.com>
>> Candela Technologies Inc  http://www.candelatech.com
>>
>
>
>


-- 
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc  http://www.candelatech.com

Thread

[PATCH] Add .set_antenna callback in ath6kl driver to remove wireless core warns Prasun Maiti <prasunmaiti87@gmail.com> - 2016-06-08 14:30 +0200
  Re: [PATCH] Add .set_antenna callback in ath6kl driver to remove  wireless core warns "Valo, Kalle" <kvalo@qca.qualcomm.com> - 2016-06-08 16:30 +0200
    Re: [PATCH] Add .set_antenna callback in ath6kl driver to remove  wireless core warns Prasun Maiti <prasunmaiti87@gmail.com> - 2016-06-08 16:40 +0200
      Re: [PATCH] Add .set_antenna callback in ath6kl driver to remove  wireless core warns "Valo, Kalle" <kvalo@qca.qualcomm.com> - 2016-06-08 16:50 +0200
        Re: [PATCH] Add .set_antenna callback in ath6kl driver to remove  wireless core warns Prasun Maiti <prasunmaiti87@gmail.com> - 2016-06-08 17:30 +0200
          Re: [PATCH] Add .set_antenna callback in ath6kl driver to remove  wireless core warns "Valo, Kalle" <kvalo@qca.qualcomm.com> - 2016-06-08 17:40 +0200
            Re: [PATCH] Add .set_antenna callback in ath6kl driver to remove  wireless core warns Prasun Maiti <prasunmaiti87@gmail.com> - 2016-06-08 17:50 +0200
              Re: [PATCH] Add .set_antenna callback in ath6kl driver to remove  wireless core warns Ben Greear <greearb@candelatech.com> - 2016-06-08 18:00 +0200
                Re: [PATCH] Add .set_antenna callback in ath6kl driver to remove  wireless core warns Prasun Maiti <prasunmaiti87@gmail.com> - 2016-06-08 18:00 +0200
                Re: [PATCH] Add .set_antenna callback in ath6kl driver to remove  wireless core warns Ben Greear <greearb@candelatech.com> - 2016-06-08 18:20 +0200
          Re: [PATCH] Add .set_antenna callback in ath6kl driver to remove  wireless core warns Julian Calaby <julian.calaby@gmail.com> - 2016-06-09 02:10 +0200
            Re: [PATCH] Add .set_antenna callback in ath6kl driver to remove  wireless core warns Prasun Maiti <prasunmaiti87@gmail.com> - 2016-06-09 07:10 +0200
            [PATCH] Add .set_antenna callback in ath6kl driver to fix wireless core warns Prasun Maiti <prasunmaiti87@gmail.com> - 2016-06-09 07:40 +0200
              Re: [PATCH] Add .set_antenna callback in ath6kl driver to fix  wireless core warns Johannes Berg <johannes@sipsolutions.net> - 2016-06-09 08:50 +0200
              Re: [PATCH] Add .set_antenna callback in ath6kl driver to fix  wireless core warns "Valo, Kalle" <kvalo@qca.qualcomm.com> - 2016-06-09 09:10 +0200
    [PATCH] Add .set_antenna callback in ath6kl driver to fix wireless core warns Prasun Maiti <prasunmaiti87@gmail.com> - 2016-06-08 17:10 +0200

csiph-web