Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1417604

Re: [PATCH] Add .set_antenna callback in ath6kl driver to remove wireless core warns

Show all headers | View raw

Please tell me if I mention that this code is untested in commit log,
then could you check the code kindly and also help me to fix this type
of warning?

On Wed, Jun 8, 2016 at 9:00 PM, Valo, Kalle <kvalo@qca.qualcomm.com> wrote:
> Prasun Maiti <prasunmaiti87@gmail.com> writes:
>
>> I am not sure it works fine. Like ath6kl driver send another cmd to
>> firmare, I have just filled up the cmd buffer with "tx_ant", and
>> "rx_ant" values, then use "ath6kl_wmi_cmd_send()" api to send the cmd
>> buffer to firmware. I have resend the patch as there are some errors
>> in the previous patch. Let me know if any modifications are needed?
>
> I don't take untested code. In some special cases it might be ok to send
> untested code but even then it needs to be clearly stated in the commit
> log that it's untested.
>
> Please resend once you have tested this, I'm dropping this now.
>
> --
> Kalle Valo



-- 
Thanks,
Prasun

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] Add .set_antenna callback in ath6kl driver to remove wireless core warns Prasun Maiti <prasunmaiti87@gmail.com> - 2016-06-08 14:30 +0200
  Re: [PATCH] Add .set_antenna callback in ath6kl driver to remove  wireless core warns "Valo, Kalle" <kvalo@qca.qualcomm.com> - 2016-06-08 16:30 +0200
    Re: [PATCH] Add .set_antenna callback in ath6kl driver to remove  wireless core warns Prasun Maiti <prasunmaiti87@gmail.com> - 2016-06-08 16:40 +0200
      Re: [PATCH] Add .set_antenna callback in ath6kl driver to remove  wireless core warns "Valo, Kalle" <kvalo@qca.qualcomm.com> - 2016-06-08 16:50 +0200
        Re: [PATCH] Add .set_antenna callback in ath6kl driver to remove  wireless core warns Prasun Maiti <prasunmaiti87@gmail.com> - 2016-06-08 17:30 +0200
          Re: [PATCH] Add .set_antenna callback in ath6kl driver to remove  wireless core warns "Valo, Kalle" <kvalo@qca.qualcomm.com> - 2016-06-08 17:40 +0200
            Re: [PATCH] Add .set_antenna callback in ath6kl driver to remove  wireless core warns Prasun Maiti <prasunmaiti87@gmail.com> - 2016-06-08 17:50 +0200
              Re: [PATCH] Add .set_antenna callback in ath6kl driver to remove  wireless core warns Ben Greear <greearb@candelatech.com> - 2016-06-08 18:00 +0200
                Re: [PATCH] Add .set_antenna callback in ath6kl driver to remove  wireless core warns Prasun Maiti <prasunmaiti87@gmail.com> - 2016-06-08 18:00 +0200
                Re: [PATCH] Add .set_antenna callback in ath6kl driver to remove  wireless core warns Ben Greear <greearb@candelatech.com> - 2016-06-08 18:20 +0200
          Re: [PATCH] Add .set_antenna callback in ath6kl driver to remove  wireless core warns Julian Calaby <julian.calaby@gmail.com> - 2016-06-09 02:10 +0200
            Re: [PATCH] Add .set_antenna callback in ath6kl driver to remove  wireless core warns Prasun Maiti <prasunmaiti87@gmail.com> - 2016-06-09 07:10 +0200
            [PATCH] Add .set_antenna callback in ath6kl driver to fix wireless core warns Prasun Maiti <prasunmaiti87@gmail.com> - 2016-06-09 07:40 +0200
              Re: [PATCH] Add .set_antenna callback in ath6kl driver to fix  wireless core warns Johannes Berg <johannes@sipsolutions.net> - 2016-06-09 08:50 +0200
              Re: [PATCH] Add .set_antenna callback in ath6kl driver to fix  wireless core warns "Valo, Kalle" <kvalo@qca.qualcomm.com> - 2016-06-09 09:10 +0200
    [PATCH] Add .set_antenna callback in ath6kl driver to fix wireless core warns Prasun Maiti <prasunmaiti87@gmail.com> - 2016-06-08 17:10 +0200

csiph-web