Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1417448

Re: [PATCH net v2] sfc: report supported link speeds on SFP connections

From Jarod Wilson <jarod@redhat.com>
Newsgroups linux.kernel
Subject Re: [PATCH net v2] sfc: report supported link speeds on SFP connections
Date 2016-06-08 15:50 +0200
Message-ID <rHM1Q-Pq-35@gated-at.bofh.it> (permalink)
References <rFMfD-58M-5@gated-at.bofh.it> <rH5Jg-7nV-31@gated-at.bofh.it> <rH7UK-da-9@gated-at.bofh.it> <rHwJs-7Uj-1@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Tue, Jun 07, 2016 at 05:20:16PM -0400, Jarod Wilson wrote:
> On Mon, Jun 06, 2016 at 02:55:29PM -0400, Jarod Wilson wrote:
> > On Mon, Jun 06, 2016 at 05:29:30PM +0100, Bert Kenward wrote:
> > > 7000-series SFC NICs connected with an SFP+ module currently fail to
> > > report any supported link speeds.
> > > 
> > > Reported-by: Jarod Wilson <jarod@redhat.com>
> > > Signed-off-by: Bert Kenward <bkenward@solarflare.com>
> > 
> > Had a feeling my cut might not have been quite right. Looks good to me.
> > 
> > Reviewed-by: Jarod Wilson <jarod@redhat.com>
> 
> ...however, upon testing, there's a gotcha. This results in my 10Gbps sfc
> nic reporting that it supports 40Gbps:
> 
> $ ethtool ens4f0
> Settings for ens4f0:
> 	Supported ports: [ FIBRE ]
> 	Supported link modes:   1000baseT/Full
> 	                        10000baseT/Full
> 	                        40000baseKR4/Full

This turned out to be a flub on my part. My local tree wasn't clean, had
some lingering test/debug crap in it that I thought I'd removed, but
clearly, hadn't. With that removed, we're all good here.

Tested-by: Jarod Wilson <jarod@redhat.com>

-- 
Jarod Wilson
jarod@redhat.com

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH net] ethernet/sfc: report supported link speeds on SFP connections Jarod Wilson <jarod@redhat.com> - 2016-06-03 03:40 +0200
  Re: [PATCH net] ethernet/sfc: report supported link speeds on SFP  connections David Miller <davem@davemloft.net> - 2016-06-04 02:00 +0200
  Re: [PATCH net] ethernet/sfc: report supported link speeds on SFP  connections Bert Kenward <bkenward@solarflare.com> - 2016-06-06 17:20 +0200
  [PATCH net v2] sfc: report supported link speeds on SFP connections Bert Kenward <bkenward@solarflare.com> - 2016-06-06 18:40 +0200
    Re: [PATCH net v2] sfc: report supported link speeds on SFP  connections Jarod Wilson <jarod@redhat.com> - 2016-06-06 21:00 +0200
      Re: [PATCH net v2] sfc: report supported link speeds on SFP  connections Jarod Wilson <jarod@redhat.com> - 2016-06-07 23:30 +0200
        Re: [PATCH net v2] sfc: report supported link speeds on SFP  connections Jarod Wilson <jarod@redhat.com> - 2016-06-08 15:50 +0200
          Re: [PATCH net v2] sfc: report supported link speeds on SFP  connections David Miller <davem@davemloft.net> - 2016-06-08 20:20 +0200

csiph-web