Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1417378
| Path | csiph.com!news.mixmin.net!aioe.org!bofh.it!news.nic.it!robomod |
|---|---|
| From | Vladimir Zapolskiy <vladimir_zapolskiy@mentor.com> |
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v3 1/6] watchdog: add set_pretimeout interface |
| Date | Wed, 08 Jun 2016 15:00:02 +0200 |
| Message-ID | <rHLfs-eb-1@gated-at.bofh.it> (permalink) |
| References | <rHt8S-5BX-25@gated-at.bofh.it> <rHt8S-5BX-23@gated-at.bofh.it> <rHFjI-4Tu-55@gated-at.bofh.it> |
| X-Original-To | Wolfram Sang <wsa@the-dreams.de> |
| User-Agent | Mozilla/5.0 (X11; Linux i686; rv:38.0) Gecko/20100101 Icedove/38.1.0 |
| MIME-Version | 1.0 |
| Content-Type | text/plain; charset="utf-8" |
| Content-Transfer-Encoding | 7bit |
| X-Originating-IP | [137.202.0.76] |
| Sender | robomod@news.nic.it |
| List-ID | <linux-kernel.vger.kernel.org> |
| X-Mailing-List | linux-kernel@vger.kernel.org |
| Approved | robomod@news.nic.it |
| Lines | 25 |
| Organization | linux.* mail to news gateway |
| X-Original-Cc | Wim Van Sebroeck <wim@iguana.be>, Guenter Roeck <linux@roeck-us.net>, Robin Gong <b38343@freescale.com>, <linux-watchdog@vger.kernel.org>, <linux-kernel@vger.kernel.org> |
| X-Original-Date | Wed, 8 Jun 2016 15:58:36 +0300 |
| X-Original-Message-ID | <5758167C.9080301@mentor.com> |
| X-Original-References | <1465321127-19522-1-git-send-email-vladimir_zapolskiy@mentor.com> <1465321127-19522-2-git-send-email-vladimir_zapolskiy@mentor.com> <20160608063458.GA1521@katana> |
| X-Original-Sender | linux-kernel-owner@vger.kernel.org |
| Xref | csiph.com linux.kernel:1417378 |
Show key headers only | View raw
Hi Wolfram, On 08.06.2016 09:34, Wolfram Sang wrote: > On Tue, Jun 07, 2016 at 08:38:42PM +0300, Vladimir Zapolskiy wrote: >> From: Robin Gong <b38343@freescale.com> >> >> Add set_pretimeout since our watchdog driver has those interfaces and >> obviously, the new common watchdog framework didn't implement this >> interface. >> >> Signed-off-by: Robin Gong <b38343@freescale.com> >> [vzapolskiy: rebased, added an inline comment to describe new interface] >> Signed-off-by: Vladimir Zapolskiy <vladimir_zapolskiy@mentor.com> > > Why didn't you just take my patch and worked on it? This would have > added the documentation Guenter explicitly requested when reviewing > Robin's patch. And it would have get rid of the bug you have in the > *_invalid function. I also don't think the split-up into three patches > is necessary here, but that might just be me. > I agree, your version is obviously more advanced, I will take it for v4. Best wishes, Vladimir
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH v3 1/6] watchdog: add set_pretimeout interface Vladimir Zapolskiy <vladimir_zapolskiy@mentor.com> - 2016-06-07 19:40 +0200
Re: [PATCH v3 1/6] watchdog: add set_pretimeout interface Guenter Roeck <linux@roeck-us.net> - 2016-06-07 22:40 +0200
Re: [PATCH v3 1/6] watchdog: add set_pretimeout interface Wolfram Sang <wsa@the-dreams.de> - 2016-06-08 08:40 +0200
Re: [PATCH v3 1/6] watchdog: add set_pretimeout interface Vladimir Zapolskiy <vladimir_zapolskiy@mentor.com> - 2016-06-08 15:00 +0200
Re: [PATCH v3 1/6] watchdog: add set_pretimeout interface Wolfram Sang <wsa@the-dreams.de> - 2016-06-09 23:20 +0200
csiph-web