Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1416914

Re: [PATCH v3 1/6] watchdog: add set_pretimeout interface

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

On Tue, Jun 07, 2016 at 08:38:42PM +0300, Vladimir Zapolskiy wrote:
> From: Robin Gong <b38343@freescale.com>
> 
> Add set_pretimeout since our watchdog driver has those interfaces and
> obviously, the new common watchdog framework didn't implement this
> interface.
> 
> Signed-off-by: Robin Gong <b38343@freescale.com>
> [vzapolskiy: rebased, added an inline comment to describe new interface]
> Signed-off-by: Vladimir Zapolskiy <vladimir_zapolskiy@mentor.com>

Why didn't you just take my patch and worked on it? This would have
added the documentation Guenter explicitly requested when reviewing
Robin's patch. And it would have get rid of the bug you have in the
*_invalid function. I also don't think the split-up into three patches
is necessary here, but that might just be me.

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v3 1/6] watchdog: add set_pretimeout interface Vladimir Zapolskiy <vladimir_zapolskiy@mentor.com> - 2016-06-07 19:40 +0200
  Re: [PATCH v3 1/6] watchdog: add set_pretimeout interface Guenter Roeck <linux@roeck-us.net> - 2016-06-07 22:40 +0200
  Re: [PATCH v3 1/6] watchdog: add set_pretimeout interface Wolfram Sang <wsa@the-dreams.de> - 2016-06-08 08:40 +0200
    Re: [PATCH v3 1/6] watchdog: add set_pretimeout interface Vladimir Zapolskiy <vladimir_zapolskiy@mentor.com> - 2016-06-08 15:00 +0200
      Re: [PATCH v3 1/6] watchdog: add set_pretimeout interface Wolfram Sang <wsa@the-dreams.de> - 2016-06-09 23:20 +0200

csiph-web