Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1416983

[PATCH] spi: rockchip: Signal unfinished DMA transfers

Show all headers | View raw

When using DMA, the transfer_one callback should return 1 because the
transfer hasn't finished yet.

A previous commit changed the function to return 0 when the DMA channels
were correctly prepared.

This manifested in Veyron boards with this message:

[ 1.983605] cros-ec-spi spi0.0: EC failed to respond in time

Signed-off-by: Tomeu Vizoso <tomeu.vizoso@collabora.com>
Fixes: ea9849113343 ("spi: rockchip: check return value of
dmaengine_prep_slave_sg")
Cc: Shawn Lin <shawn.lin@rock-chips.com>
Cc: Heiko Stuebner <heiko@sntech.de>
Cc: Javier Martinez Canillas <javier@osg.samsung.com>
---
 drivers/spi/spi-rockchip.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/spi/spi-rockchip.c b/drivers/spi/spi-rockchip.c
index cd89682065b9..1026e180eed7 100644
--- a/drivers/spi/spi-rockchip.c
+++ b/drivers/spi/spi-rockchip.c
@@ -578,7 +578,7 @@ static int rockchip_spi_transfer_one(
 		struct spi_device *spi,
 		struct spi_transfer *xfer)
 {
-	int ret = 1;
+	int ret = 0;
 	struct rockchip_spi *rs = spi_master_get_devdata(master);
 
 	WARN_ON(readl_relaxed(rs->regs + ROCKCHIP_SPI_SSIENR) &&
@@ -627,6 +627,8 @@ static int rockchip_spi_transfer_one(
 			spi_enable_chip(rs, 1);
 			ret = rockchip_spi_prepare_dma(rs);
 		}
+		/* successful DMA prepare means the transfer is in progress */
+		ret = ret ? ret : 1;
 	} else {
 		spi_enable_chip(rs, 1);
 		ret = rockchip_spi_pio_transfer(rs);
-- 
2.5.5

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH] spi: rockchip: Signal unfinished DMA transfers Tomeu Vizoso <tomeu.vizoso@collabora.com> - 2016-06-08 09:40 +0200
  Applied "spi: rockchip: Signal unfinished DMA transfers" to the spi tree Mark Brown <broonie@kernel.org> - 2016-06-08 13:00 +0200
  Re: [PATCH] spi: rockchip: Signal unfinished DMA transfers Mark Brown <broonie@kernel.org> - 2016-06-08 13:00 +0200
  Re: [PATCH] spi: rockchip: Signal unfinished DMA transfers Heiko Stübner <heiko@sntech.de> - 2016-06-08 14:30 +0200

csiph-web