Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1415053

Re: [PATCH 3/2] xen-pciback: drop rom_init()

From "Jan Beulich" <JBeulich@suse.com>
Newsgroups linux.kernel
Subject Re: [PATCH 3/2] xen-pciback: drop rom_init()
Date 2016-06-06 16:00 +0200
Message-ID <rH3ep-5FP-1@gated-at.bofh.it> (permalink)
References <rGXLI-2fW-55@gated-at.bofh.it> <rGYoq-2vy-3@gated-at.bofh.it> <rH2BI-5r5-7@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

>>> On 06.06.16 at 15:09, <boris.ostrovsky@oracle.com> wrote:
> On 06/06/2016 04:47 AM, Jan Beulich wrote:
>> It's identical to bar_init() now.
>>
>> Signed-off-by: Jan Beulich <jbeulich@suse.com>
>> ---
>> I'm sorry for this 3/2 - I only now noticed that this additional
>> simplification is now possible.
> 
> I wonder whether we should also move content of read_dev_bar() into
> bar_init(). Especially given that it's not really reading a BAR but
> rather initializing the stashed value.

I had considered that too, but then thought the splitting out of
that logic could as well stay. If we were to do that, I'd in fact
prefer merging patches 2 and 3 (plus this additional adjustment).

Jan

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/2] xen-pciback: correct and clean up BAR handling "Jan Beulich" <JBeulich@suse.com> - 2016-06-06 10:10 +0200
  [PATCH 2/2] xen-pciback: clean up read_dev_bar() "Jan Beulich" <JBeulich@suse.com> - 2016-06-06 10:20 +0200
    Re: [PATCH 2/2] xen-pciback: clean up read_dev_bar() Boris Ostrovsky <boris.ostrovsky@oracle.com> - 2016-06-06 15:10 +0200
  [PATCH 1/2] xen-pciback: return proper values during BAR  sizing "Jan Beulich" <JBeulich@suse.com> - 2016-06-06 10:20 +0200
    Re: [PATCH 1/2] xen-pciback: return proper values during BAR sizing Boris Ostrovsky <boris.ostrovsky@oracle.com> - 2016-06-06 15:10 +0200
      Re: [PATCH 1/2] xen-pciback: return proper values during BAR  sizing "Jan Beulich" <JBeulich@suse.com> - 2016-06-06 16:00 +0200
        Re: [PATCH 1/2] xen-pciback: return proper values during BAR sizing Boris Ostrovsky <boris.ostrovsky@oracle.com> - 2016-06-06 16:40 +0200
  [PATCH 3/2] xen-pciback: drop rom_init() "Jan Beulich" <JBeulich@suse.com> - 2016-06-06 10:50 +0200
    Re: [PATCH 3/2] xen-pciback: drop rom_init() Boris Ostrovsky <boris.ostrovsky@oracle.com> - 2016-06-06 15:20 +0200
      Re: [PATCH 3/2] xen-pciback: drop rom_init() "Jan Beulich" <JBeulich@suse.com> - 2016-06-06 16:00 +0200
        Re: [PATCH 3/2] xen-pciback: drop rom_init() Boris Ostrovsky <boris.ostrovsky@oracle.com> - 2016-06-06 16:40 +0200

csiph-web