Re: [patch] futex: Fix v4.6+ ltp futex_wait04 regression

From	Mike Galbraith <umgwanakikbuti@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [patch] futex: Fix v4.6+ ltp futex_wait04 regression
Date	2016-06-06 15:50 +0200
Message-ID	<rH34K-5B9-23@gated-at.bofh.it> (permalink)
References	<rGZku-34Q-13@gated-at.bofh.it> <rH2s2-5nS-27@gated-at.bofh.it> <rH2V4-5xv-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Mon, 2016-06-06 at 15:34 +0200, Mike Galbraith wrote:
> On Mon, 2016-06-06 at 15:07 +0200, Peter Zijlstra wrote:
> 
> > > @@ -654,12 +666,14 @@ get_futex_key(u32 __user *uaddr, int fsh
> > >  
> > >  > > 	> > 	> > key->both.offset |= FUT_OFF_INODE;
> > > /* inode-based key */
> > >  > > 	> > 	> > key->shared.inode = inode;
> > > -> > 	> > 	> > key->shared.pgoff =
> > > basepage_index(page);
> > > +> > 	> > 	> > key->shared.pgoff =
> > > basepage_index(pinned);
> > 
> > But this seems to be the actual fix;
> 
> Yup, the three 'pinned' lines alone work just fine.

I was going by what the code used to look like.

#ifdef CONFIG_TRANSPARENT_HUGEPAGE
...
#else
        page_head = compound_head(page);
        if (page != page_head) {
                get_page(page_head);
                put_page(page);
        }
#endif

That all went away, but the pinned page that we used in the end was
stable until Mel's optimization landed, leaving me thinking I needed to
do both.  Hohum, close but no banana.

	-Mike

Thread

[patch] futex: Fix v4.6+ ltp futex_wait04 regression Mike Galbraith <umgwanakikbuti@gmail.com> - 2016-06-06 11:50 +0200
  Re: [patch] futex: Fix v4.6+ ltp futex_wait04 regression Peter Zijlstra <peterz@infradead.org> - 2016-06-06 15:10 +0200
    Re: [patch] futex: Fix v4.6+ ltp futex_wait04 regression Mike Galbraith <umgwanakikbuti@gmail.com> - 2016-06-06 15:40 +0200
      Re: [patch] futex: Fix v4.6+ ltp futex_wait04 regression Mike Galbraith <umgwanakikbuti@gmail.com> - 2016-06-06 15:50 +0200
  Re: [patch] futex: Fix v4.6+ ltp futex_wait04 regression Mel Gorman <mgorman@suse.de> - 2016-06-07 13:00 +0200
    Re: [patch] futex: Fix v4.6+ ltp futex_wait04 regression Mel Gorman <mgorman@suse.de> - 2016-06-07 13:30 +0200

csiph-web