[PATCH v3 02/30] staging: unisys: visorchipset change -1 return value

From	David Kershner <david.kershner@unisys.com>
Newsgroups	linux.kernel
Subject	[PATCH v3 02/30] staging: unisys: visorchipset change -1 return value
Date	2016-06-04 19:30 +0200
Message-ID	<rGnyx-3X7-1@gated-at.bofh.it> (permalink)
References	<rGnyx-3X7-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

From: Erik Arfvidson <erik.arfvidson@unisys.com>

This patch changes the vague -1 return value to -EINVAL
It also modifies the caller of parahotplug_request_complete
to check the return value and return appropriate result.

Signed-off-by: Erik Arfvidson <erik.arfvidson@unisys.com>
Signed-off-by: David Kershner <david.kershner@unisys.com>
Reviewed-by: Tim Sell <Timothy.Sell@unisys.com>
---
 drivers/staging/unisys/visorbus/visorchipset.c | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/unisys/visorbus/visorchipset.c b/drivers/staging/unisys/visorbus/visorchipset.c
index 5ba5936..7f44913 100644
--- a/drivers/staging/unisys/visorbus/visorchipset.c
+++ b/drivers/staging/unisys/visorbus/visorchipset.c
@@ -1613,7 +1613,7 @@ parahotplug_request_complete(int id, u16 active)
 	}
 
 	spin_unlock(&parahotplug_request_list_lock);
-	return -1;
+	return -EINVAL;
 }
 
 /*
@@ -2036,11 +2036,14 @@ static ssize_t devicedisabled_store(struct device *dev,
 				    const char *buf, size_t count)
 {
 	unsigned int id;
+	int err;
 
 	if (kstrtouint(buf, 10, &id))
 		return -EINVAL;
 
-	parahotplug_request_complete(id, 0);
+	err = parahotplug_request_complete(id, 0);
+	if (err < 0)
+		return err;
 	return count;
 }
 
-- 
1.9.1

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

[PATCH v3 02/30] staging: unisys: visorchipset change -1 return value David Kershner <david.kershner@unisys.com> - 2016-06-04 19:30 +0200

csiph-web