Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1413799

[PATCH v3 04/30] staging: unisys: visorbus: remove unused module parameters

From David Kershner <david.kershner@unisys.com>
Newsgroups linux.kernel
Subject [PATCH v3 04/30] staging: unisys: visorbus: remove unused module parameters
Date 2016-06-04 19:30 +0200
Message-ID <rGnyD-3X7-5@gated-at.bofh.it> (permalink)
References <rGnyx-3X7-3@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


From: David Binder <david.binder@unisys.com>

Removes unused module parameters from visorbus_main.c, in response to
findings by SonarQube.

Signed-off-by: David Binder <david.binder@unisys.com>
Signed-off-by: David Kershner <david.kershner@unisys.com>
Reviewed-by: Tim Sell <Timothy.Sell@unisys.com>
---
 drivers/staging/unisys/visorbus/visorbus_main.c | 9 +--------
 1 file changed, 1 insertion(+), 8 deletions(-)

diff --git a/drivers/staging/unisys/visorbus/visorbus_main.c b/drivers/staging/unisys/visorbus/visorbus_main.c
index 2ed9628..71bff07 100644
--- a/drivers/staging/unisys/visorbus/visorbus_main.c
+++ b/drivers/staging/unisys/visorbus/visorbus_main.c
@@ -27,10 +27,9 @@
 #define MYDRVNAME "visorbus"
 
 /* module parameters */
-static int visorbus_debug;
 static int visorbus_forcematch;
 static int visorbus_forcenomatch;
-static int visorbus_debugref;
+
 #define SERIALLOOPBACKCHANADDR (100 * 1024 * 1024)
 
 /* Display string that is guaranteed to be no longer the 99 characters*/
@@ -1332,9 +1331,6 @@ visorbus_exit(void)
 	remove_bus_type();
 }
 
-module_param_named(debug, visorbus_debug, int, S_IRUGO);
-MODULE_PARM_DESC(visorbus_debug, "1 to debug");
-
 module_param_named(forcematch, visorbus_forcematch, int, S_IRUGO);
 MODULE_PARM_DESC(visorbus_forcematch,
 		 "1 to force a successful dev <--> drv match");
@@ -1342,6 +1338,3 @@ MODULE_PARM_DESC(visorbus_forcematch,
 module_param_named(forcenomatch, visorbus_forcenomatch, int, S_IRUGO);
 MODULE_PARM_DESC(visorbus_forcenomatch,
 		 "1 to force an UNsuccessful dev <--> drv match");
-
-module_param_named(debugref, visorbus_debugref, int, S_IRUGO);
-MODULE_PARM_DESC(visorbus_debugref, "1 to debug reference counting");
-- 
1.9.1

Back to linux.kernel | Previous | NextNext in thread | Find similar | Unroll thread


Thread

[PATCH v3 04/30] staging: unisys: visorbus: remove unused module parameters David Kershner <david.kershner@unisys.com> - 2016-06-04 19:30 +0200
  Re: [PATCH v3 04/30] staging: unisys: visorbus: remove unused module  parameters Neil Horman <nhorman@redhat.com> - 2016-06-07 15:30 +0200
    RE: [PATCH v3 04/30] staging: unisys: visorbus: remove unused module  parameters "Binder, David Anthony" <David.Binder@unisys.com> - 2016-06-08 04:30 +0200
      Re: [PATCH v3 04/30] staging: unisys: visorbus: remove unused module  parameters Neil Horman <nhorman@redhat.com> - 2016-06-08 15:10 +0200
        RE: [PATCH v3 04/30] staging: unisys: visorbus: remove unused module  parameters "Binder, David Anthony" <David.Binder@unisys.com> - 2016-06-08 16:50 +0200
          Re: [PATCH v3 04/30] staging: unisys: visorbus: remove unused module  parameters Neil Horman <nhorman@redhat.com> - 2016-06-08 17:10 +0200

csiph-web