Re: [PATCH 1/2] KVM: x86: avoid simultaneous queueing of both IRQ and SMI

From	Wanpeng Li <kernellwp@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/2] KVM: x86: avoid simultaneous queueing of both IRQ and SMI
Date	2016-06-06 10:30 +0200
Message-ID	<rGY53-2mT-7@gated-at.bofh.it> (permalink)
References	(1 earlier) <rFdBf-8pl-5@gated-at.bofh.it> <rFhvf-2p3-117@gated-at.bofh.it> <rFiKC-3t1-15@gated-at.bofh.it> <rGwVb-1sD-1@gated-at.bofh.it> <rGXVo-2jv-17@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

2016-06-06 16:10 GMT+08:00 Paolo Bonzini <pbonzini@redhat.com>:
>
>
> On 05/06/2016 05:28, Wanpeng Li wrote:
>>> > No, I don't think so, the existing req_immediate_exit case is only after
>>> > a VMLAUNCH/VMRESUME vmexit, in which case we already have a
>>> >
>>> >         if (vmx->nested.nested_run_pending)
>>> >                 kvm_make_request(KVM_REQ_EVENT, vcpu);
>>> >
>>> > in vmx_vcpu_run.
>> Do you think this can be removed since it blindly request a
>> KVM_REQ_EVENT even if there is no still-pending event to L1 which
>> blocked by nested_run_pending, however, req_immediate_exit can
>> indicate there is a pending event blocked by nested_run_pending and
>> the request KVM_REQUEST_EVENT added in your patch can guarantee inject
>> this pending event in the next nested vmexit.
>
> Yes, I think so.

Yeah, maybe somebody who is interested in can clean it up and confirm
there is no regression. :)

Regards,
Wanpeng Li

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 1/2] KVM: x86: avoid simultaneous queueing of both IRQ and SMI Paolo Bonzini <pbonzini@redhat.com> - 2016-06-01 14:40 +0200
  Re: [PATCH 1/2] KVM: x86: avoid simultaneous queueing of both IRQ  and SMI Radim Krčmář <rkrcmar@redhat.com> - 2016-06-01 18:50 +0200
    Re: [PATCH 1/2] KVM: x86: avoid simultaneous queueing of both IRQ and  SMI Paolo Bonzini <pbonzini@redhat.com> - 2016-06-01 20:10 +0200
      Re: [PATCH 1/2] KVM: x86: avoid simultaneous queueing of both IRQ and SMI Wanpeng Li <kernellwp@gmail.com> - 2016-06-05 05:30 +0200
        Re: [PATCH 1/2] KVM: x86: avoid simultaneous queueing of both IRQ and  SMI Paolo Bonzini <pbonzini@redhat.com> - 2016-06-06 10:20 +0200
          Re: [PATCH 1/2] KVM: x86: avoid simultaneous queueing of both IRQ and SMI Wanpeng Li <kernellwp@gmail.com> - 2016-06-06 10:30 +0200

csiph-web