Re: [PATCH v2 2/5] of/numa: fix a memory@ node can only contains one memory block

From	Hanjun Guo <hanjun.guo@linaro.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2 2/5] of/numa: fix a memory@ node can only contains one memory block
Date	2016-06-06 10:10 +0200
Message-ID	<rGXLI-2fW-29@gated-at.bofh.it> (permalink)
References	(1 earlier) <rDIJb-78P-1@gated-at.bofh.it> <rFkMp-4JV-7@gated-at.bofh.it> <rFpVL-7U8-9@gated-at.bofh.it> <rFTTP-1rX-1@gated-at.bofh.it> <rGRwB-5WK-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi Leizhen,

On 2016/6/6 9:24, Leizhen (ThunderTown) wrote:
>
>
> On 2016/6/3 17:45, Will Deacon wrote:
>> On Thu, Jun 02, 2016 at 09:36:40AM +0800, Leizhen (ThunderTown) wrote:
>>> On 2016/6/2 4:13, Rob Herring wrote:
>>>> I believe you still need this and not the one above. You only need it
>>>> within the loop if you return. Otherwise, the last node always need to
>>>> be put.
>>>
>>> OK. Thanks.
>>>
>>> Addition with Matthias's suggestion, I will move "return" into this patch,
>>> so that this of_node_put(np) can be safely removed.
>>
>> Do you want to include Kefeng's [1] patches in your series too? We don't
>> need two sets of related NUMA cleanups :)
>
> Yes, It's originally suggested by Joe Perches.

I think Will suggested us to add Kefeng's NUMA cleanup patches into
yours and send a new version, just see comments from Will,

 > Actually, I see you've already respun the series, do don't worry about
 > doing another version just for this.

Will, correct me if I'm wrong.

Thanks
Hanjun

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH v2 2/5] of/numa: fix a memory@ node can only contains one  memory block Rob Herring <robh+dt@kernel.org> - 2016-06-01 22:20 +0200
  Re: [PATCH v2 2/5] of/numa: fix a memory@ node can only contains one  memory block "Leizhen (ThunderTown)" <thunder.leizhen@huawei.com> - 2016-06-02 03:50 +0200
    Re: [PATCH v2 2/5] of/numa: fix a memory@ node can only contains one  memory block Will Deacon <will.deacon@arm.com> - 2016-06-03 11:50 +0200
      Re: [PATCH v2 2/5] of/numa: fix a memory@ node can only contains one  memory block Will Deacon <will.deacon@arm.com> - 2016-06-03 12:00 +0200
      Re: [PATCH v2 2/5] of/numa: fix a memory@ node can only contains one  memory block "Leizhen (ThunderTown)" <thunder.leizhen@huawei.com> - 2016-06-06 03:30 +0200
        Re: [PATCH v2 2/5] of/numa: fix a memory@ node can only contains one  memory block Hanjun Guo <hanjun.guo@linaro.org> - 2016-06-06 10:10 +0200

csiph-web