Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1412990

Re: [PATCH v2 2/5] of/numa: fix a memory@ node can only contains one memory block

Show all headers | View raw

On Fri, Jun 03, 2016 at 10:45:20AM +0100, Will Deacon wrote:
> On Thu, Jun 02, 2016 at 09:36:40AM +0800, Leizhen (ThunderTown) wrote:
> > On 2016/6/2 4:13, Rob Herring wrote:
> > > I believe you still need this and not the one above. You only need it
> > > within the loop if you return. Otherwise, the last node always need to
> > > be put.
> > 
> > OK. Thanks.
> > 
> > Addition with Matthias's suggestion, I will move "return" into this patch,
> > so that this of_node_put(np) can be safely removed.
> 
> Do you want to include Kefeng's [1] patches in your series too? We don't
> need two sets of related NUMA cleanups :)

Actually, I see you've already respun the series, do don't worry about
doing another version just for this.

Will

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH v2 2/5] of/numa: fix a memory@ node can only contains one  memory block Rob Herring <robh+dt@kernel.org> - 2016-06-01 22:20 +0200
  Re: [PATCH v2 2/5] of/numa: fix a memory@ node can only contains one  memory block "Leizhen (ThunderTown)" <thunder.leizhen@huawei.com> - 2016-06-02 03:50 +0200
    Re: [PATCH v2 2/5] of/numa: fix a memory@ node can only contains one  memory block Will Deacon <will.deacon@arm.com> - 2016-06-03 11:50 +0200
      Re: [PATCH v2 2/5] of/numa: fix a memory@ node can only contains one  memory block Will Deacon <will.deacon@arm.com> - 2016-06-03 12:00 +0200
      Re: [PATCH v2 2/5] of/numa: fix a memory@ node can only contains one  memory block "Leizhen (ThunderTown)" <thunder.leizhen@huawei.com> - 2016-06-06 03:30 +0200
        Re: [PATCH v2 2/5] of/numa: fix a memory@ node can only contains one  memory block Hanjun Guo <hanjun.guo@linaro.org> - 2016-06-06 10:10 +0200

csiph-web