Re: powerpc/nvram: Fix an incorrect partition merge

Path	csiph.com!news.mixmin.net!aioe.org!gothmog.csi.it!bofh.it!news.nic.it!robomod
From	xinhui <xinhui.pan@linux.vnet.ibm.com>
Newsgroups	linux.kernel
Subject	Re: powerpc/nvram: Fix an incorrect partition merge
Date	Mon, 06 Jun 2016 07:40:01 +0200
Message-ID	<rGVqx-DI-7@gated-at.bofh.it> (permalink)
References	<rFVLY-2AV-19@gated-at.bofh.it>
X-Ibm-Helo	d23dlp02.au.ibm.com
X-Ibm-Mailfrom	xinhui.pan@linux.vnet.ibm.com
X-Ibm-Rcptto	linux-kernel@vger.kernel.org
User-Agent	Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.8.0
MIME-Version	1.0
Content-Type	text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding	8bit
X-Tm-As-Mml	disable
X-Content-Scanned	Fidelis XPS MAILER
X-Cbid	16060605-0040-0000-0000-000001AE7483
X-Ibm-Av-Detection	SAVI=unused REMOTE=unused XFE=unused
X-Cbparentid	16060605-0041-0000-0000-000009D045CC
X-Proofpoint-Virus-Version	vendor=fsecure engine=2.50.10432:,, definitions=2016-06-06_03:,, signatures=0
X-Proofpoint-Spam-Details	rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=2 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1604210000 definitions=main-1606060068
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	37
Organization	linux.* mail to news gateway
X-Original-Cc	Andrzej Hajda <a.hajda@samsung.com>, Christophe Jaillet <christophe.jaillet@wanadoo.fr>, Hari Bathini <hbathini@linux.vnet.ibm.com>, Paul Mackerras <paulus@samba.org>, tglx@linutronix.de, Nathan Fontenot <nfont@linux.vnet.ibm.com>
X-Original-Date	Mon, 06 Jun 2016 13:31:30 +0800
X-Original-Message-ID	<57550AB2.8090500@linux.vnet.ibm.com>
X-Original-References	<3rLj4P6Swcz9t6B@ozlabs.org>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1414652

Show key headers only | View raw

On 2016年06月03日 19:47, Michael Ellerman wrote:
> On Thu, 2015-10-12 at 07:30:02 UTC, xinhui wrote:
>> From: Pan Xinhui <xinhui.pan@linux.vnet.ibm.com>
>>
>> When we merge two contiguous partitions whose signatures are marked
>> NVRAM_SIG_FREE, We need update prev's length and checksum, then write it
>> to nvram, not cur's. So lets fix this mistake now.
>>
>> Also use memset instead of strncpy to set the partition's name. It's
>> more readable if we want to fill up with duplicate chars .
>
> Does this ever happen in practice? ie. should we backport the fix to stable
> kernels?
>

I did not see that nvram warning in practice. BUT I suggest to backport it to stable kernel. :)

Let me recall the story. :)
In past days, I was using pstore to keep some kernel logs. and sometimes I found my own logs and the panic logs did not show.
pstore use a fixed-address reserved memory In x86 while nvram instead in ppc.

Then I spent some days to review the nvram codes.
And worked out three patches to fix all issues that I found in nvram. BUT looks like I only sent out two of them. :)
I lost the third patch maybe...

> Has it always been broken?
>

no. after nvram partition corruption hit, all nvram partitions will be erased and re-alloc after the second machine reboot.
I don't know who does it but i guess it is the firmware. :)

thanks
xinhui
> cheers
>

Thread

Re: powerpc/nvram: Fix an incorrect partition merge Michael Ellerman <mpe@ellerman.id.au> - 2016-06-03 13:50 +0200
  Re: powerpc/nvram: Fix an incorrect partition merge xinhui <xinhui.pan@linux.vnet.ibm.com> - 2016-06-06 07:40 +0200
    Re: powerpc/nvram: Fix an incorrect partition merge Stewart Smith <stewart@linux.vnet.ibm.com> - 2016-06-07 07:30 +0200
    Re: powerpc/nvram: Fix an incorrect partition merge Michael Ellerman <mpe@ellerman.id.au> - 2016-06-07 13:40 +0200

csiph-web