Re: powerpc/nvram: Fix an incorrect partition merge

From	Michael Ellerman <mpe@ellerman.id.au>
Newsgroups	linux.kernel
Subject	Re: powerpc/nvram: Fix an incorrect partition merge
Date	2016-06-03 13:50 +0200
Message-ID	<rFVLY-2AV-19@gated-at.bofh.it> (permalink)
References	<qE3Zw-31E-9@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Thu, 2015-10-12 at 07:30:02 UTC, xinhui wrote:
> From: Pan Xinhui <xinhui.pan@linux.vnet.ibm.com>
> 
> When we merge two contiguous partitions whose signatures are marked
> NVRAM_SIG_FREE, We need update prev's length and checksum, then write it
> to nvram, not cur's. So lets fix this mistake now.
> 
> Also use memset instead of strncpy to set the partition's name. It's
> more readable if we want to fill up with duplicate chars .

Does this ever happen in practice? ie. should we backport the fix to stable
kernels?

Has it always been broken?

cheers

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: powerpc/nvram: Fix an incorrect partition merge Michael Ellerman <mpe@ellerman.id.au> - 2016-06-03 13:50 +0200
  Re: powerpc/nvram: Fix an incorrect partition merge xinhui <xinhui.pan@linux.vnet.ibm.com> - 2016-06-06 07:40 +0200
    Re: powerpc/nvram: Fix an incorrect partition merge Stewart Smith <stewart@linux.vnet.ibm.com> - 2016-06-07 07:30 +0200
    Re: powerpc/nvram: Fix an incorrect partition merge Michael Ellerman <mpe@ellerman.id.au> - 2016-06-07 13:40 +0200

csiph-web