Re: [PATCH v2 2/4] gpio: Allow PC/104 devices on X86_64

From	Pavel Machek <pavel@ucw.cz>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2 2/4] gpio: Allow PC/104 devices on X86_64
Date	2016-06-03 23:00 +0200
Message-ID	<rG4md-83b-7@gated-at.bofh.it> (permalink)
References	<rC5Ae-2Hk-3@gated-at.bofh.it> <rC5Ae-2Hk-9@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi!

> With the introduction of the ISA_BUS_API Kconfig option, ISA-style
> drivers may be built for X86_64 architectures. This patch changes the
> ISA Kconfig option dependency of the PC/104 drivers to ISA_BUS_API, thus
> allowing them to build for X86_64 as they are expected to.
> 
> Cc: Guenter Roeck <linux@roeck-us.net>
> Cc: Linus Walleij <linus.walleij@linaro.org>
> Signed-off-by: William Breathitt Gray <vilhelm.gray@gmail.com>
> ---
>  drivers/gpio/Kconfig | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig
> index 48da857..dc6da77 100644
> --- a/drivers/gpio/Kconfig
> +++ b/drivers/gpio/Kconfig
> @@ -530,7 +530,7 @@ menu "Port-mapped I/O GPIO drivers"
>  
>  config GPIO_104_DIO_48E
>  	tristate "ACCES 104-DIO-48E GPIO support"
> -	depends on ISA
> +	depends on ISA_BUS_API
>  	select GPIOLIB_IRQCHIP
>  	help
>  	  Enables GPIO support for the ACCES 104-DIO-48E series

Should we do "depends on PC104" here, because that is what it really
means, and have PC104 enabled when ISA_BUS_API is enabled or something
like that?

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH v2 2/4] gpio: Allow PC/104 devices on X86_64 Pavel Machek <pavel@ucw.cz> - 2016-06-03 23:00 +0200
  Re: [PATCH v2 2/4] gpio: Allow PC/104 devices on X86_64 William Breathitt Gray <vilhelm.gray@gmail.com> - 2016-06-03 23:20 +0200
    Re: [PATCH v2 2/4] gpio: Allow PC/104 devices on X86_64 Pavel Machek <pavel@ucw.cz> - 2016-06-04 09:20 +0200
      Re: [PATCH v2 2/4] gpio: Allow PC/104 devices on X86_64 William Breathitt Gray <vilhelm.gray@gmail.com> - 2016-06-04 13:20 +0200
        Re: [PATCH v2 2/4] gpio: Allow PC/104 devices on X86_64 Pavel Machek <pavel@ucw.cz> - 2016-06-05 21:30 +0200
          Re: [PATCH v2 2/4] gpio: Allow PC/104 devices on X86_64 William Breathitt Gray <vilhelm.gray@gmail.com> - 2016-06-05 22:10 +0200

csiph-web