Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1411551

[RFC][PATCH 3/5] hi655x-pmic: Fixup issue with un-acked interrupts

Show all headers | View raw

While trying to get the powerkey to function, I found
when pressing the key, I would get infinitely repeating
interrupts.

After digging around a bit, it seems we didn't set the
ack_base value for the regmap irqchip logic, so nothing
was acking the interrupt.

This patch adds the ack_base, which seems to make things
work.

Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: Rob Herring <robh+dt@kernel.org>
Cc: Pawel Moll <pawel.moll@arm.com>
Cc: Mark Rutland <mark.rutland@arm.com>
Cc: Ian Campbell <ijc+devicetree@hellion.org.uk>
Cc: Kumar Gala <galak@codeaurora.org>
Cc: Lee Jones <lee.jones@linaro.org>
Cc: Jorge Ramirez-Ortiz <jorge.ramirez-ortiz@linaro.org>
Cc: Wei Xu <xuwei5@hisilicon.com>
Cc: Guodong Xu <guodong.xu@linaro.org>
Signed-off-by: John Stultz <john.stultz@linaro.org>
---
 drivers/mfd/hi655x-pmic.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/mfd/hi655x-pmic.c b/drivers/mfd/hi655x-pmic.c
index 3511035..4a3fdbc 100644
--- a/drivers/mfd/hi655x-pmic.c
+++ b/drivers/mfd/hi655x-pmic.c
@@ -50,6 +50,7 @@ static const struct regmap_irq_chip hi655x_irq_chip = {
 	.num_regs = 1,
 	.num_irqs = ARRAY_SIZE(hi655x_irqs),
 	.status_base = HI655X_IRQ_STAT_BASE,
+	.ack_base = HI655X_IRQ_STAT_BASE,
 	.mask_base = HI655X_IRQ_MASK_BASE,
 };
 
-- 
1.9.1

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[RFC][PATCH 0/5] Hi655x powerkey support for HiKey John Stultz <john.stultz@linaro.org> - 2016-06-01 23:30 +0200
  [RFC][PATCH 5/5] arm64: dts: Add powerkey info to pmic for hi6220-hikey John Stultz <john.stultz@linaro.org> - 2016-06-01 23:30 +0200
    Re: [RFC][PATCH 5/5] arm64: dts: Add powerkey info to pmic for hi6220-hikey Rob Herring <robh+dt@kernel.org> - 2016-06-01 23:50 +0200
  [RFC][PATCH 2/5] hi655x-pmic: Make hi655x pmic logic probe child nodes in the dt John Stultz <john.stultz@linaro.org> - 2016-06-01 23:30 +0200
    Re: [RFC][PATCH 2/5] hi655x-pmic: Make hi655x pmic logic probe child  nodes in the dt Lee Jones <lee.jones@linaro.org> - 2016-06-08 16:40 +0200
      Re: [RFC][PATCH 2/5] hi655x-pmic: Make hi655x pmic logic probe child  nodes in the dt John Stultz <john.stultz@linaro.org> - 2016-06-08 19:30 +0200
        Re: [RFC][PATCH 2/5] hi655x-pmic: Make hi655x pmic logic probe child  nodes in the dt Lee Jones <lee.jones@linaro.org> - 2016-06-09 16:50 +0200
  [RFC][PATCH 3/5] hi655x-pmic: Fixup issue with un-acked interrupts John Stultz <john.stultz@linaro.org> - 2016-06-01 23:30 +0200
    Re: [RFC][PATCH 3/5] hi655x-pmic: Fixup issue with un-acked  interrupts Lee Jones <lee.jones@linaro.org> - 2016-06-08 16:40 +0200

csiph-web