[RFC][PATCH 2/5] hi655x-pmic: Make hi655x pmic logic probe child nodes in the dt

From	John Stultz <john.stultz@linaro.org>
Newsgroups	linux.kernel
Subject	[RFC][PATCH 2/5] hi655x-pmic: Make hi655x pmic logic probe child nodes in the dt
Date	2016-06-01 23:30 +0200
Message-ID	<rFlSa-5vL-11@gated-at.bofh.it> (permalink)
References	<rFlS9-5vL-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

In trying to wire up the powerkey driver, I found I
needed to add this to get the pmic logic to probe
child nodes in the dt data.

With this patch, child nodes get properly probed.

Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: Rob Herring <robh+dt@kernel.org>
Cc: Pawel Moll <pawel.moll@arm.com>
Cc: Mark Rutland <mark.rutland@arm.com>
Cc: Ian Campbell <ijc+devicetree@hellion.org.uk>
Cc: Kumar Gala <galak@codeaurora.org>
Cc: Lee Jones <lee.jones@linaro.org>
Cc: Jorge Ramirez-Ortiz <jorge.ramirez-ortiz@linaro.org>
Cc: Wei Xu <xuwei5@hisilicon.com>
Cc: Guodong Xu <guodong.xu@linaro.org>
Signed-off-by: John Stultz <john.stultz@linaro.org>
---
 drivers/mfd/hi655x-pmic.c | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/drivers/mfd/hi655x-pmic.c b/drivers/mfd/hi655x-pmic.c
index 05ddc78..3511035 100644
--- a/drivers/mfd/hi655x-pmic.c
+++ b/drivers/mfd/hi655x-pmic.c
@@ -39,6 +39,11 @@ static const struct regmap_irq hi655x_irqs[] = {
 	{ .reg_offset = 0, .mask = RESERVE_INT },
 };
 
+static const struct of_device_id of_hi655x_pmic_child_match_tbl[] = {
+	{ .compatible = "hisilicon,hi6552-powerkey", },
+	{ /* end */ }
+};
+
 static const struct regmap_irq_chip hi655x_irq_chip = {
 	.name = "hi655x-pmic",
 	.irqs = hi655x_irqs,
@@ -122,6 +127,9 @@ static int hi655x_pmic_probe(struct platform_device *pdev)
 
 	platform_set_drvdata(pdev, pmic);
 
+	/* populate sub nodes */
+	of_platform_populate(np, of_hi655x_pmic_child_match_tbl, NULL, dev);
+
 	ret = mfd_add_devices(dev, PLATFORM_DEVID_AUTO, hi655x_pmic_devs,
 			      ARRAY_SIZE(hi655x_pmic_devs), NULL, 0, NULL);
 	if (ret) {
-- 
1.9.1

Thread

[RFC][PATCH 0/5] Hi655x powerkey support for HiKey John Stultz <john.stultz@linaro.org> - 2016-06-01 23:30 +0200
  [RFC][PATCH 5/5] arm64: dts: Add powerkey info to pmic for hi6220-hikey John Stultz <john.stultz@linaro.org> - 2016-06-01 23:30 +0200
    Re: [RFC][PATCH 5/5] arm64: dts: Add powerkey info to pmic for hi6220-hikey Rob Herring <robh+dt@kernel.org> - 2016-06-01 23:50 +0200
  [RFC][PATCH 2/5] hi655x-pmic: Make hi655x pmic logic probe child nodes in the dt John Stultz <john.stultz@linaro.org> - 2016-06-01 23:30 +0200
    Re: [RFC][PATCH 2/5] hi655x-pmic: Make hi655x pmic logic probe child  nodes in the dt Lee Jones <lee.jones@linaro.org> - 2016-06-08 16:40 +0200
      Re: [RFC][PATCH 2/5] hi655x-pmic: Make hi655x pmic logic probe child  nodes in the dt John Stultz <john.stultz@linaro.org> - 2016-06-08 19:30 +0200
        Re: [RFC][PATCH 2/5] hi655x-pmic: Make hi655x pmic logic probe child  nodes in the dt Lee Jones <lee.jones@linaro.org> - 2016-06-09 16:50 +0200
  [RFC][PATCH 3/5] hi655x-pmic: Fixup issue with un-acked interrupts John Stultz <john.stultz@linaro.org> - 2016-06-01 23:30 +0200
    Re: [RFC][PATCH 3/5] hi655x-pmic: Fixup issue with un-acked  interrupts Lee Jones <lee.jones@linaro.org> - 2016-06-08 16:40 +0200

csiph-web