Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1411446

Re: [PATCH] hwmon: (fam15h_power) Disable preemption when reading registers

Show all headers | View raw

On Wed, Jun 01, 2016 at 03:41:26PM +0200, Borislav Petkov wrote:
> On Wed, Jun 01, 2016 at 06:22:59AM -0700, Guenter Roeck wrote:
> > An explanation would be helpful. Is this a bug fix ?
> 
> That's a good point - yes, it is necessary. Both smp_processor_id()
> *and* smp_call_function_many() need to be called with preemption
> disabled.
> 
> It did fire the BUG thing in check_preemption_disabled() with 4.7-rc1
> here without those fixes.
> 
It would be great if you can add at least part of the BUG message as well
as a Fixes: tag into the patch description. If you had, I would not have
asked, saving both of us time ;-).

> But, we need the other patch too -
> 
> "[PATCH] x86/cpu/AMD: Extend X86_FEATURE_TOPOEXT workaround to newer models"
> 
> because the cpumask generation in read_registers() doesn't work on those
> Carrizo CPUs.
> 
> IINM, the breakage came in during this merge window so we don't have to
> CC:stable but both should be sent to Linus as fixes for 4.7.
> 
> You could sync with Ingo who takes/acks what... but they could go
> through tip and hwmon tree too, I don't see a hard dependency between
> the two - they'd only need to be in 4.7-final.
> 

Sounds like separate trees should be fine then.

Thanks,
Guenter

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] hwmon: (fam15h_power) Disable preemption when reading registers Borislav Petkov <bp@alien8.de> - 2016-06-01 12:10 +0200
  Re: [PATCH] hwmon: (fam15h_power) Disable preemption when reading  registers Guenter Roeck <linux@roeck-us.net> - 2016-06-01 15:30 +0200
    Re: [PATCH] hwmon: (fam15h_power) Disable preemption when reading  registers Borislav Petkov <bp@alien8.de> - 2016-06-01 15:50 +0200
      Re: [PATCH] hwmon: (fam15h_power) Disable preemption when reading  registers Guenter Roeck <linux@roeck-us.net> - 2016-06-01 20:20 +0200
        Re: [PATCH] hwmon: (fam15h_power) Disable preemption when reading  registers Borislav Petkov <bp@alien8.de> - 2016-06-02 09:30 +0200
          Re: [PATCH] hwmon: (fam15h_power) Disable preemption when reading  registers Thomas Gleixner <tglx@linutronix.de> - 2016-06-02 10:00 +0200
            Re: [PATCH] hwmon: (fam15h_power) Disable preemption when reading  registers Borislav Petkov <bp@alien8.de> - 2016-06-02 10:00 +0200
              Re: [PATCH] hwmon: (fam15h_power) Disable preemption when reading  registers Borislav Petkov <bp@alien8.de> - 2016-06-02 10:20 +0200
                Re: [PATCH] hwmon: (fam15h_power) Disable preemption when reading  registers Guenter Roeck <linux@roeck-us.net> - 2016-06-03 20:20 +0200
                Re: [PATCH] hwmon: (fam15h_power) Disable preemption when reading  registers Borislav Petkov <bp@alien8.de> - 2016-06-03 20:30 +0200
                Re: [PATCH] hwmon: (fam15h_power) Disable preemption when reading  registers Guenter Roeck <linux@roeck-us.net> - 2016-06-04 17:00 +0200
    Re: [PATCH] hwmon: (fam15h_power) Disable preemption when reading  registers "Huang, Ray" <Ray.Huang@amd.com> - 2016-06-01 17:50 +0200
      Re: [PATCH] hwmon: (fam15h_power) Disable preemption when reading  registers "Huang, Ray" <Ray.Huang@amd.com> - 2016-06-01 18:20 +0200

csiph-web