Re: [2/3] hwmon: xgene: Adds hwmon driver

From	Guenter Roeck <linux@roeck-us.net>
Newsgroups	linux.kernel
Subject	Re: [2/3] hwmon: xgene: Adds hwmon driver
Date	2016-06-01 20:20 +0200
Message-ID	<rFiUi-3wl-7@gated-at.bofh.it> (permalink)
References	<rztpo-Ox-21@gated-at.bofh.it> <rEnW2-8jz-11@gated-at.bofh.it> <rF7vP-4JC-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Tue, May 31, 2016 at 11:00:05PM -0700, Hoan Tran wrote:
> Hi Guenter,
> 
> >
> > Overall, I have to say that the code is quite complex due to the repeated
> > checks for ACPI. I am close to suggest having two separate drivers,
> > one for ACPI and one for non-ACPI. Any chance to separate ACPI vs. non-ACPI
> > code a bit better ?
> 
> How about create separate rx_cb functions for ACPI and non-ACPI ?

Yes, that would be great if it is possible.

> As almost functions are the same between ACPI and non-ACPI, I thought
> keep the same driver is still OK, isn't it ?
> 
If you can separate the ACPI code from the non-ACPI code a bit better than
right now, yes.

Thanks,
Guenter

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [2/3] hwmon: xgene: Adds hwmon driver Hoan Tran <hotran@apm.com> - 2016-06-01 08:10 +0200
  Re: [2/3] hwmon: xgene: Adds hwmon driver Guenter Roeck <linux@roeck-us.net> - 2016-06-01 20:20 +0200

csiph-web