Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1413227

Re: [PATCH] nvme: lightnvme: make MLC num_pairs little endian

Path csiph.com!aioe.org!bofh.it!news.nic.it!robomod
From Matias Bjørling <m@bjorling.me>
Newsgroups linux.kernel
Subject Re: [PATCH] nvme: lightnvme: make MLC num_pairs little endian
Date Fri, 03 Jun 2016 15:20:01 +0200
Message-ID <rFXb3-3BY-3@gated-at.bofh.it> (permalink)
References <rFWI1-3dd-15@gated-at.bofh.it>
Dkim-Signature v=1; a=rsa-sha256; c=relaxed/relaxed; d=bjorling.me; s=google; h=subject:to:references:cc:from:organization:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=dBpJ5N8ru4THuOrud8sCMiaW4Wg39KqFrnNMqsLk72o=; b=hH9hJ8lBWjdtUDkcr3dZP3HTZ7pX5XNGF77EutdX7tZsRYXADYBJGmpaBzIhU0CKPe KtXHqz8AoWE6REs9RzFuNDXslAtaGhuUpchmL38O4Lx0aMUdBfArl803McOBj2Y9GDni QWOMzxFXd5XRz2zdiWV1DeOEea9TYYR0flFaY=
X-Google-Dkim-Signature v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:subject:to:references:cc:from:organization :message-id:date:user-agent:mime-version:in-reply-to :content-transfer-encoding; bh=dBpJ5N8ru4THuOrud8sCMiaW4Wg39KqFrnNMqsLk72o=; b=bP3bAxd0q9UJOi3xnCsjN0oglEf1RxSONtemszimOo6oNA4gjtozOei1N8g2HFmPFV WR7Q1i5bgiDv6KF+VWcdpErlrryYptwnqZcKqogUBq0OGscoQ1PdsGd06GfnfN2B5EeW 7PbKv4q1F7u68oLXdHVUNEQQE4JQoETI9CtRsYJOBO+we/Qdm6XDdtywVrfI5nEL1xSd us8JOeuObL3uJrybjD/c+ILBj7xAAbmmMRdoveVVdQZoSWAo8XMdR4bDQNMWO0K7irSE dw1ur+IE/gKscuQGjyGucm2LUkCSwQEmzEcZXZGOKO+QLeX4/YjJqpnBZMTZ2JQ6fWix 074Q==
X-Gm-Message-State ALyK8tIo9fl7kKhyGqsAFQ2SCSVFYMyBeDRi2CK9v1X3dOU7bw4DQIICLQ8depEowqjW/g==
X-Received by 10.194.104.138 with SMTP id ge10mr3256395wjb.85.1464959857956; Fri, 03 Jun 2016 06:17:37 -0700 (PDT)
Organization Paletta
User-Agent Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0
MIME-Version 1.0
Content-Type text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding 7bit
Sender robomod@news.nic.it
List-ID <linux-kernel.vger.kernel.org>
X-Mailing-List linux-kernel@vger.kernel.org
Approved robomod@news.nic.it
Lines 28
X-Original-Cc Keith Busch <keith.busch@intel.com>, linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org
X-Original-Date Fri, 3 Jun 2016 15:17:35 +0200
X-Original-Message-ID <5751836F.7060407@bjorling.me>
X-Original-References <1464957858-59392-1-git-send-email-jthumshirn@suse.de>
X-Original-Sender linux-kernel-owner@vger.kernel.org
Xref csiph.com linux.kernel:1413227

Show key headers only | View raw


On 06/03/2016 02:44 PM, Johannes Thumshirn wrote:
> According to the OpenChannel SSD interface specification the NAND flash
> MLC page pairing information's number of page page pairings field is the
> first two bytes in the MLC Page Pairing data structure. The hardware's
> data structure itself is little endian so annotate it as such, like the
> rest of lighnvm's data structures.
>
> Signed-off-by: Johannes Thumshirn <jthumshirn@suse.de>
> ---
>   drivers/nvme/host/lightnvm.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/nvme/host/lightnvm.c b/drivers/nvme/host/lightnvm.c
> index 9461dd6..ea36cbb 100644
> --- a/drivers/nvme/host/lightnvm.c
> +++ b/drivers/nvme/host/lightnvm.c
> @@ -156,7 +156,7 @@ struct nvme_nvm_completion {
>
>   #define NVME_NVM_LP_MLC_PAIRS 886
>   struct nvme_nvm_lp_mlc {
> -	__u16			num_pairs;
> +	__le16			num_pairs;
>   	__u8			pairs[NVME_NVM_LP_MLC_PAIRS];
>   };
>
>

Thanks Johannes. Applied for 4.8.

Back to linux.kernel | Previous | NextPrevious in thread | Find similar | Unroll thread


Thread

[PATCH] nvme: lightnvme: make MLC num_pairs little endian Johannes Thumshirn <jthumshirn@suse.de> - 2016-06-03 14:50 +0200
  Re: [PATCH] nvme: lightnvme: make MLC num_pairs little endian Matias Bjørling <m@bjorling.me> - 2016-06-03 15:20 +0200

csiph-web