Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1413201 > unrolled thread
| Started by | Johannes Thumshirn <jthumshirn@suse.de> |
|---|---|
| First post | 2016-06-03 14:50 +0200 |
| Last post | 2016-06-03 15:20 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH] nvme: lightnvme: make MLC num_pairs little endian Johannes Thumshirn <jthumshirn@suse.de> - 2016-06-03 14:50 +0200
Re: [PATCH] nvme: lightnvme: make MLC num_pairs little endian Matias Bjørling <m@bjorling.me> - 2016-06-03 15:20 +0200
| From | Johannes Thumshirn <jthumshirn@suse.de> |
|---|---|
| Date | 2016-06-03 14:50 +0200 |
| Subject | [PATCH] nvme: lightnvme: make MLC num_pairs little endian |
| Message-ID | <rFWI1-3dd-15@gated-at.bofh.it> |
According to the OpenChannel SSD interface specification the NAND flash
MLC page pairing information's number of page page pairings field is the
first two bytes in the MLC Page Pairing data structure. The hardware's
data structure itself is little endian so annotate it as such, like the
rest of lighnvm's data structures.
Signed-off-by: Johannes Thumshirn <jthumshirn@suse.de>
---
drivers/nvme/host/lightnvm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/nvme/host/lightnvm.c b/drivers/nvme/host/lightnvm.c
index 9461dd6..ea36cbb 100644
--- a/drivers/nvme/host/lightnvm.c
+++ b/drivers/nvme/host/lightnvm.c
@@ -156,7 +156,7 @@ struct nvme_nvm_completion {
#define NVME_NVM_LP_MLC_PAIRS 886
struct nvme_nvm_lp_mlc {
- __u16 num_pairs;
+ __le16 num_pairs;
__u8 pairs[NVME_NVM_LP_MLC_PAIRS];
};
--
1.8.5.6
[toc] | [next] | [standalone]
| From | Matias Bjørling <m@bjorling.me> |
|---|---|
| Date | 2016-06-03 15:20 +0200 |
| Message-ID | <rFXb3-3BY-3@gated-at.bofh.it> |
| In reply to | #1413201 |
On 06/03/2016 02:44 PM, Johannes Thumshirn wrote:
> According to the OpenChannel SSD interface specification the NAND flash
> MLC page pairing information's number of page page pairings field is the
> first two bytes in the MLC Page Pairing data structure. The hardware's
> data structure itself is little endian so annotate it as such, like the
> rest of lighnvm's data structures.
>
> Signed-off-by: Johannes Thumshirn <jthumshirn@suse.de>
> ---
> drivers/nvme/host/lightnvm.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/nvme/host/lightnvm.c b/drivers/nvme/host/lightnvm.c
> index 9461dd6..ea36cbb 100644
> --- a/drivers/nvme/host/lightnvm.c
> +++ b/drivers/nvme/host/lightnvm.c
> @@ -156,7 +156,7 @@ struct nvme_nvm_completion {
>
> #define NVME_NVM_LP_MLC_PAIRS 886
> struct nvme_nvm_lp_mlc {
> - __u16 num_pairs;
> + __le16 num_pairs;
> __u8 pairs[NVME_NVM_LP_MLC_PAIRS];
> };
>
>
Thanks Johannes. Applied for 4.8.
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web