Re: [PATCH v2 2/7] iio: adc: ad7791: claim direct mode when writing frequency

From	Jonathan Cameron <jic23@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2 2/7] iio: adc: ad7791: claim direct mode when writing frequency
Date	2016-06-03 14:20 +0200
Message-ID	<rFWf1-32g-41@gated-at.bofh.it> (permalink)
References	<rF66J-3Iw-7@gated-at.bofh.it> <rFjQl-44X-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 01/06/16 20:10, Lars-Peter Clausen wrote:
> On 06/01/2016 06:35 AM, Alison Schofield wrote:
>> Driver was checking for direct mode and trying to lock it, but
>> left a gap where mode could change before the desired operation.
>> Use iio_device_claim_direct_mode() to guarantee device stays in
>> direct mode.
>>
>> Refactor function to clarify look-up followed by lock sequence.
>>
>> Signed-off-by: Alison Schofield <amsfield22@gmail.com>
>> Cc: Daniel Baluta <daniel.baluta@gmail.com>
> 
> Looks good, thanks.
> 
> Acked-by: Lars-Peter Clausen <lars@metafoo.de>
Applied - thanks.
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-iio" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v2 2/7] iio: adc: ad7791: claim direct mode when writing  frequency Alison Schofield <amsfield22@gmail.com> - 2016-06-01 06:40 +0200
  Re: [PATCH v2 2/7] iio: adc: ad7791: claim direct mode when writing  frequency Lars-Peter Clausen <lars@metafoo.de> - 2016-06-01 21:20 +0200
    Re: [PATCH v2 2/7] iio: adc: ad7791: claim direct mode when writing  frequency Jonathan Cameron <jic23@kernel.org> - 2016-06-03 14:20 +0200

csiph-web