Re: [PATCH 2/2] pci: Add PCIe driver for Rockchip Soc

From	Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 2/2] pci: Add PCIe driver for Rockchip Soc
Date	2016-06-03 11:00 +0200
Message-ID	<rFT7r-Wy-19@gated-at.bofh.it> (permalink)
References	<rAPQS-4i2-9@gated-at.bofh.it> <rAPQS-4i2-7@gated-at.bofh.it> <rDp3P-3nf-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Fri, May 27, 2016 at 01:25:14PM +0100, Marc Zyngier wrote:

[...]

> > +	} else {
> > +		bus = pci_scan_root_bus(&pdev->dev, 0,
> > +					&rockchip_pcie_ops, port, &res);
> > +	}
> > +	if (!bus)
> > +		return -ENOMEM;
> > +
> > +	if (!pci_has_flag(PCI_PROBE_ONLY)) {
> 
> Why do you have catter for the PCI_PROBE_ONLY case? Nobody should ever
> use that for properly implemented HW.

I think that's just copy and paste and it is a useless check given
that the only way we can set that flag on ARM/ARM64 is through DT
(of_pci_check_probe_only()) and I doubt that systems probing this
driver really require a PCI_PROBE_ONLY set-up.

So, unless you can explain to us why it is really needed, please
remove the:

if (!pci_has_flag(PCI_PROBE_ONLY))

check.

Lorenzo

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH 2/2] pci: Add PCIe driver for Rockchip Soc Lorenzo Pieralisi <lorenzo.pieralisi@arm.com> - 2016-06-03 11:00 +0200
  Re: [PATCH 2/2] pci: Add PCIe driver for Rockchip Soc Marc Zyngier <marc.zyngier@arm.com> - 2016-06-03 11:10 +0200

csiph-web