Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1412880
| Path | csiph.com!eternal-september.org!feeder.eternal-september.org!aioe.org!news.servidellagleba.it!bofh.it!news.nic.it!robomod |
|---|---|
| From | "M'boumba Cedric Madianga" <cedric.madianga@gmail.com> |
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v2 3/5] ARM: dts: Add I2C1 support for STM32F429 SoC |
| Date | Fri, 03 Jun 2016 10:00:02 +0200 |
| Message-ID | <rFSbo-od-21@gated-at.bofh.it> (permalink) |
| References | <rFBNf-71V-7@gated-at.bofh.it> <rFBNg-71V-31@gated-at.bofh.it> <rFDvI-87Q-5@gated-at.bofh.it> |
| Dkim-Signature | v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=vhtJN2XF7SZ9fPdyX4Wvvu+WLf7SEOvvtS8vwEoajsk=; b=sE2xhUi++G5pHVGALpfrKirKINxiQ0iSIytlqk1Shw3fnIcvevQiIwOUBFmwVpNx0r uX6FoJs1rpVlXJggkrHcUtGjdOUA15B8vTy2KIqFbCVZquxk7vdb84eaAMF/HX4jh66r Hy11klvfuuVgvMXi+lQtLAxvFBq3m/BaIaHESlF2uPlN4+Ql9+e1CC5WyAWwwKfaRBX/ ULSXQ3ZBulnBQtKkp4smcd53vyXeD8mk9inTFYvMTsor5ht1HykMUZgPrIG6tnUMYBJz 8MLS07PJTCzhAVQGGkgUAtt7owxL7wgKocTKOehAYvnaR5nXtxU6ILyIS6tmkldowMn8 ttfA== |
| X-Google-Dkim-Signature | v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=vhtJN2XF7SZ9fPdyX4Wvvu+WLf7SEOvvtS8vwEoajsk=; b=BNy6rjAB7pBJ+veDjrzlGmKa1srBnLMzR+eC5ULNfKxVT4DN/6X2zRs4HgyXHTMqV4 L1L/wReKQCSAQNXUW6nk1HVI+Dxc0GB1nN3pdwVJK5A1cPLDJxTLxmSKOkro1S96ixma RCaP8uJD0liOxxB3SyKaBeOVY9qFp5sYFcLHNp25DH+2ADnpy540t6q9Rjbq0nfaqnb+ 3UzTUURGx53H9dG/34FtkaMQGjXKZKJbkszqbXEDmvOJdSaB3JvCU1e3ZBVmbylAcgzw eKdjU2agcEn2erT8qon5Sd/rjMpZdRl8R7PiXYDBBKeu5ozDr9C4b4doPlyCa7RdaTmt WDqg== |
| X-Gm-Message-State | ALyK8tIPZnWa6XI3FS7RluFGMOtta+jf1wrqY2sN/sgKrjZT4nsHES/DKWQXISYdD+88A2NjMJpEd45wP2R7Yw== |
| X-Received | by 10.66.166.6 with SMTP id zc6mr3519135pab.21.1464940632027; Fri, 03 Jun 2016 00:57:12 -0700 (PDT) |
| MIME-Version | 1.0 |
| Content-Type | text/plain; charset=UTF-8 |
| Sender | robomod@news.nic.it |
| List-ID | <linux-kernel.vger.kernel.org> |
| X-Mailing-List | linux-kernel@vger.kernel.org |
| Approved | robomod@news.nic.it |
| Lines | 52 |
| Organization | linux.* mail to news gateway |
| X-Original-Cc | Patrice Chotard <patrice.chotard@st.com>, Wolfram Sang <wsa@the-dreams.de>, Rob Herring <robh+dt@kernel.org>, linux@armlinux.org.uk, linux-i2c@vger.kernel.org, "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>, "linux-arm-kernel@lists.infradead.org" <linux-arm-kernel@lists.infradead.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org> |
| X-Original-Date | Fri, 3 Jun 2016 09:57:11 +0200 |
| X-Original-Message-ID | <CAOAejn13uZq320pGgYY7PENC1VK+Og22S_yRYkcVAP6O87fTrw@mail.gmail.com> |
| X-Original-References | <1464877568-21897-1-git-send-email-cedric.madianga@gmail.com> <1464877568-21897-4-git-send-email-cedric.madianga@gmail.com> <CALszF6D4K1GsFdb0z3Lkb=EJdhzNnZNnAxeyCZGq36+Cnwf+_A@mail.gmail.com> |
| X-Original-Sender | linux-kernel-owner@vger.kernel.org |
| Xref | csiph.com linux.kernel:1412880 |
Show key headers only | View raw
2016-06-02 18:07 GMT+02:00 Maxime Coquelin <mcoquelin.stm32@gmail.com>:
> 2016-06-02 16:26 GMT+02:00 M'boumba Cedric Madianga <cedric.madianga@gmail.com>:
>> Signed-off-by: Patrice Chotard <patrice.chotard@st.com>
>> Signed-off-by: M'boumba Cedric Madianga <cedric.madianga@gmail.com>
>> ---
>> arch/arm/boot/dts/stm32f429.dtsi | 24 ++++++++++++++++++++++++
>> 1 file changed, 24 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/stm32f429.dtsi b/arch/arm/boot/dts/stm32f429.dtsi
>> index 434d4b9..d5857eb 100644
>> --- a/arch/arm/boot/dts/stm32f429.dtsi
>> +++ b/arch/arm/boot/dts/stm32f429.dtsi
>> @@ -323,6 +323,18 @@
>> slew-rate = <2>;
>> };
>> };
>> +
>> + i2c1_sda_pin: i2c1_sda@0 {
>> + pins {
>> + pinmux = <STM32F429_PB9_FUNC_I2C1_SDA>;
>> + drive-open-drain;
>> + };
>> + };
>> + i2c1_scl_pin: i2c1_scl@0 {
>> + pins {
>> + pinmux = <STM32F429_PB6_FUNC_I2C1_SCL>;
>> + };
>> + };
>> };
> Shouldn't be preferrable to group the two functions in a single one,
I agree. It is better.
>
> usart1_pins_a: usart1@0 {
> pins1 {
> pinmux = <STM32F429_PA9_FUNC_USART1_TX>;
> bias-disable;
> drive-push-pull;
> slew-rate = <0>;
> };
> pins2 {
> pinmux = <STM32F429_PA10_FUNC_USART1_RX>;
> bias-disable;
> };
> };
>
> Also, I would prefer the phandle to be suffixed with the port number,
> as multiple muxing options are available, for example "i2c1_pins_b".
Ok understood. I will fix that in the V3.
Thanks
>
> Thanks,
> Maxime
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH v2 0/5] Add support for the STM32F4 I2C M'boumba Cedric Madianga <cedric.madianga@gmail.com> - 2016-06-02 16:30 +0200
[PATCH v2 3/5] ARM: dts: Add I2C1 support for STM32F429 SoC M'boumba Cedric Madianga <cedric.madianga@gmail.com> - 2016-06-02 16:30 +0200
Re: [PATCH v2 3/5] ARM: dts: Add I2C1 support for STM32F429 SoC Maxime Coquelin <mcoquelin.stm32@gmail.com> - 2016-06-02 18:20 +0200
Re: [PATCH v2 3/5] ARM: dts: Add I2C1 support for STM32F429 SoC "M'boumba Cedric Madianga" <cedric.madianga@gmail.com> - 2016-06-03 10:00 +0200
[PATCH v2 5/5] ARM: configs: Add I2C support for STM32 defconfig M'boumba Cedric Madianga <cedric.madianga@gmail.com> - 2016-06-02 16:30 +0200
csiph-web