Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1412683

Re: [PATCH 00/11] cpufreq: Keep policy->freq_table sorted

Show all headers | View raw

On Friday, June 03, 2016 05:31:34 AM Viresh Kumar wrote:
> On 02-06-16, 22:35, Rafael J. Wysocki wrote:
> > Quoting from this very cover letter "This change allows us to remove
> > the (duplicate) sorted-freq-table, which
> > was added by following series:", so why to add it in the first place?
> 
> Okay, that's fine.
> 
> > Besides, there already is a number of tables (per policy which in some
> > important cases pretty much means per CPU) in cpufreq that contain
> > more-or-less the same information.  For example, if acpi-cpufreq is in
> > use, the ACPI layer has a table coming from _PSS, the driver creates
> > freq_table to pass to the core and there is an additional one for the
> > stats.  And your series adds one more just so it is ordered.  Come on.
> 
> Of course.
> 
> > If you want to clean that up, fine, but please don't do that in a
> > hurry.  Let's talk about it a bit more without sending any more
> > patches in that area for the time being.
> 
> Okay, I will send all the fixes that you can apply cleanly now in a
> separate set.

Thanks!

> So, yeah, I get your overall concern. What about this:
> - A single patchset to make sure the current policy->freq_table is
>   always sorted in Ascending order of frequencies.

Be careful here.  acpi-cpufreq sorts the table in the descending order
and at least acpi_cpufreq_fast_switch() assumes that.

> - And this sorting will be done per policy only when the policy is
>   first created.
> - Which would eventually mean merging this series with the [v2 0/2]
>   one.
> 
> Will that work ?

Well, it may. :-)

I would like you to talk to Steve and agree on the approach, including which
changes to make first, though.  You are both from Linaro after all ...

Thanks,
Rafael

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 00/11] cpufreq: Keep policy->freq_table sorted Viresh Kumar <viresh.kumar@linaro.org> - 2016-06-02 16:20 +0200
  [PATCH 04/11] cpufreq: blackfin: Use 'index' only to index into policy->freq_table Viresh Kumar <viresh.kumar@linaro.org> - 2016-06-02 16:20 +0200
  [PATCH 01/11] ARM: davinci: Sort frequency table Viresh Kumar <viresh.kumar@linaro.org> - 2016-06-02 16:30 +0200
  [PATCH 05/11] cpufreq: elanfreq: Use 'index' only to index into policy->freq_table Viresh Kumar <viresh.kumar@linaro.org> - 2016-06-02 16:30 +0200
  [PATCH 10/11] cpufreq: Keep a single (sorted) freq_table Viresh Kumar <viresh.kumar@linaro.org> - 2016-06-02 16:30 +0200
  [PATCH 02/11] cpufreq: davinci: Reuse cpufreq_generic_frequency_table_verify() Viresh Kumar <viresh.kumar@linaro.org> - 2016-06-02 16:30 +0200
  [PATCH 11/11] cpufreq: drivers: Free frequency tables after being used Viresh Kumar <viresh.kumar@linaro.org> - 2016-06-02 16:30 +0200
  [PATCH 08/11] cpufreq: imx: Use 'index' only to index into policy->freq_table Viresh Kumar <viresh.kumar@linaro.org> - 2016-06-02 16:30 +0200
  [PATCH 03/11] cpufreq: Use policy->freq_table in ->target_index() Viresh Kumar <viresh.kumar@linaro.org> - 2016-06-02 16:30 +0200
  [PATCH 09/11] cpufreq: maple: Use 'index' only to index into policy->freq_table Viresh Kumar <viresh.kumar@linaro.org> - 2016-06-02 16:30 +0200
  Re: [PATCH 00/11] cpufreq: Keep policy->freq_table sorted "Rafael J. Wysocki" <rafael@kernel.org> - 2016-06-02 17:10 +0200
    Re: [PATCH 00/11] cpufreq: Keep policy->freq_table sorted Viresh Kumar <viresh.kumar@linaro.org> - 2016-06-02 18:00 +0200
      Re: [PATCH 00/11] cpufreq: Keep policy->freq_table sorted "Rafael J. Wysocki" <rafael@kernel.org> - 2016-06-02 22:40 +0200
        Re: [PATCH 00/11] cpufreq: Keep policy->freq_table sorted Viresh Kumar <viresh.kumar@linaro.org> - 2016-06-03 02:10 +0200
          Re: [PATCH 00/11] cpufreq: Keep policy->freq_table sorted "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2016-06-03 03:40 +0200
            Re: [PATCH 00/11] cpufreq: Keep policy->freq_table sorted Viresh Kumar <viresh.kumar@linaro.org> - 2016-06-03 05:20 +0200

csiph-web