Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1409143
| From | Carlo Caione <carlo@caione.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH 1/3] watchdog: Add Meson GXBB Watchdog Driver |
| Date | 2016-05-30 16:00 +0200 |
| Message-ID | <rEvTA-4U9-23@gated-at.bofh.it> (permalink) |
| References | <rEvqx-4K0-17@gated-at.bofh.it> <rEvqx-4K0-23@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On 30/05/16 15:29, Neil Armstrong wrote: > Add watchdog specific driver for Amlogic Meson GXBB SoC. > > Signed-off-by: Neil Armstrong <narmstrong@baylibre.com> > + > +#define GXBB_WDT_CTRL1_REG 0x4 ... > +#define GXBB_WDT_CTRL_EE_RESET_NOW BIT(26) ... > +#define GXBB_WDT_CTRL_IRQ_EN BIT(23) ... > +#define GXBB_WDT_CTRL_XTAL_SEL (0) ... > +#define GXBB_WDT_CTRL_CLK81_SEL BIT(19) ... > +#define GXBB_WDT_CTRL1_GPIO_PULSE BIT(17) ... > +#define GXBB_WDT_CTRL1_GPIO_POL_RESET_0 BIT(16) > +#define GXBB_WDT_CTRL1_GPIO_POL_RESET_1 (0) > +#define GXBB_WDT_CTRL1_GPIO_PULSE_CNT (BIT(16) - 1) nit: all these defines are not used at all in the driver. You can remove them Thanks! -- Carlo Caione
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH 0/3] watchdog: Add Amlogic Meson GXBB Watchdog Timer driver Neil Armstrong <narmstrong@baylibre.com> - 2016-05-30 15:30 +0200
[PATCH 3/3] ARM64: dts: amlogic: meson-gxbb: Add watchdog node Neil Armstrong <narmstrong@baylibre.com> - 2016-05-30 15:30 +0200
[PATCH 1/3] watchdog: Add Meson GXBB Watchdog Driver Neil Armstrong <narmstrong@baylibre.com> - 2016-05-30 15:30 +0200
Re: [PATCH 1/3] watchdog: Add Meson GXBB Watchdog Driver Carlo Caione <carlo@caione.org> - 2016-05-30 16:00 +0200
Re: [PATCH 1/3] watchdog: Add Meson GXBB Watchdog Driver Guenter Roeck <linux@roeck-us.net> - 2016-05-30 16:50 +0200
Re: [PATCH 1/3] watchdog: Add Meson GXBB Watchdog Driver Guenter Roeck <linux@roeck-us.net> - 2016-05-30 19:00 +0200
Re: [PATCH 0/3] watchdog: Add Amlogic Meson GXBB Watchdog Timer driver Carlo Caione <carlo@caione.org> - 2016-05-30 15:50 +0200
Re: [PATCH 0/3] watchdog: Add Amlogic Meson GXBB Watchdog Timer driver Neil Armstrong <narmstrong@baylibre.com> - 2016-05-30 16:20 +0200
[PATCH 2/3] dt-bindings: watchdog: Add Meson GXBB Watchdog bindings Neil Armstrong <narmstrong@baylibre.com> - 2016-05-30 16:20 +0200
csiph-web