Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1409144

Re: [PATCH] staging: iio: fix ad7606_spi regression

Show all headers | View raw

On Mon, May 30, 2016 at 3:50 PM, Arnd Bergmann <arnd@arndb.de> wrote:
> As pointed out by Geert Uytterhoeven, the patch was incorrect
> and breaks the driver, which was fortunately pointed out by
> this gcc warning:
>
> drivers/staging/iio/adc/ad7606_spi.c: In function ‘ad7606_spi_read_block’:
> drivers/staging/iio/adc/ad7606_spi.c:34: warning: ‘data’ is used uninitialized in this function
>
> The effect of the patch is that the data is copied into
> a random memory location (from the uninitialized pointer)
> instead of being byteswapped in place.
>
> This adds the initialization for the 'data' variable back
> to restore the original behavior.
>
> Cc: Geert Uytterhoeven <geert@linux-m68k.org>
> Cc: Ksenija Stanojevic <ksenija.stanojevic@gmail.com>
> Fixes: 87787e5ef727 ("Staging: iio: Fix sparse endian warning")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Acked-by: Geert Uytterhoeven <geert@linux-m68k.org>

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH] staging: iio: fix ad7606_spi regression Geert Uytterhoeven <geert@linux-m68k.org> - 2016-05-30 16:00 +0200

csiph-web