Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1410591

[glibc] preadv/pwritev question

Show all headers | View raw

Hi Chris,

In path a63c7fa18a (Add sysdeps/unix/sysv/linux/generic/.) you add
this:
+++ b/sysdeps/unix/sysv/linux/generic/wordsize-32/preadv.c

[...]

+static ssize_t
+do_preadv (int fd, const struct iovec *vector, int count, off_t
offset)
+{
+  assert (sizeof (offset) == 4);
+  return INLINE_SYSCALL (preadv, __ALIGNMENT_COUNT (5, 6), fd,
+                         vector, count, __ALIGNMENT_ARG
+                         __LONG_LONG_PAIR (offset >> 31, offset));
+}
+

And this is the code that is picked up if I choose wordsize-32 for my
AARCH64/ILP32. So I have questions.

1. What is the assert for? We agreed that all new ABIs will be 64-bit
off_t only.

I fixed it internally like this:
+#ifndef __OFF_T_MATCHES_OFF64_T
        assert (sizeof (offset) == 4);
+#endif

There is a bunch of similar assertions in glibc.

2. This one looks weird:
__LONG_LONG_PAIR (offset >> 31, offset))
Why 31-bit offset? And why you don't mask 2nd argument?
Later in your patch I see this:
+static ssize_t
+do_preadv64 (int fd, const struct iovec *vector, int count, off64_t
offset)

+{
+  return INLINE_SYSCALL (preadv, __ALIGNMENT_COUNT (5, 6), fd,
+                         vector, count, __ALIGNMENT_ARG
+                         __LONG_LONG_PAIR ((off_t) (offset >> 32),
+                                           (off_t) (offset & 0xffffffff)));
+}

And it looks correct to me. If 1st version is correct as well, I think
it should be commented.

Yury.

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[glibc] preadv/pwritev question Yury Norov <ynorov@caviumnetworks.com> - 2016-05-31 22:10 +0200
  Re: [glibc] preadv/pwritev question Chris Metcalf <cmetcalf@mellanox.com> - 2016-05-31 23:40 +0200
    Re: [glibc] preadv/pwritev question Mike Frysinger <vapier@gentoo.org> - 2016-06-01 00:10 +0200

csiph-web