Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1410038

Re: [PATCH 1/3] mmc: fix mmc mode selection for HS-DDR and higher

Show all headers | View raw

On Sun, May 29, 2016 at 9:04 AM, Chen-Yu Tsai <wens@csie.org> wrote:
> When IS_ERR_VALUE was removed from the mmc core code, it was replaced
> with a simple not-zero check. This does not work, as the value checked
> is the return value for mmc_select_bus_width, which returns the set
> bit width on success. This made eMMC modes higher than HS-DDR unusable.
>
> Fix this by checking for a positive return value instead.
>
> Fixes: 287980e49ffc ("remove lots of IS_ERR_VALUE abuses")
> Cc: Arnd Bergmann <arnd@arndb.de>
> Signed-off-by: Chen-Yu Tsai <wens@csie.org>
> ---
>  drivers/mmc/core/mmc.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>

Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>

Could you be so kind and pick it up as fast as possible for current
RC? Half of my boards fail (because they work on eMMC) so testing
patches before applying is limited.

Best regards,
Krzysztof

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 1/3] mmc: fix mmc mode selection for HS-DDR and higher Chen-Yu Tsai <wens@csie.org> - 2016-05-29 09:10 +0200
  Re: [PATCH 1/3] mmc: fix mmc mode selection for HS-DDR and higher Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-05-31 11:40 +0200
  Re: [PATCH 1/3] mmc: fix mmc mode selection for HS-DDR and higher Jaehoon Chung <jh80.chung@samsung.com> - 2016-06-01 03:30 +0200
  Re: [PATCH 1/3] mmc: fix mmc mode selection for HS-DDR and higher Shawn Lin <shawn.lin@rock-chips.com> - 2016-06-01 04:40 +0200
  Re: [PATCH 1/3] mmc: fix mmc mode selection for HS-DDR and higher Marcel Ziswiler <marcel@ziswiler.com> - 2016-06-01 11:30 +0200
  Re: [PATCH 1/3] mmc: fix mmc mode selection for HS-DDR and higher Bjorn Andersson <bjorn.andersson@linaro.org> - 2016-06-01 21:10 +0200
    Re: [PATCH 1/3] mmc: fix mmc mode selection for HS-DDR and higher Chen-Yu Tsai <wens@csie.org> - 2016-06-02 10:10 +0200
  Re: [PATCH 1/3] mmc: fix mmc mode selection for HS-DDR and higher Ulf Hansson <ulf.hansson@linaro.org> - 2016-06-02 10:40 +0200
    Re: [PATCH 1/3] mmc: fix mmc mode selection for HS-DDR and higher Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-06-02 11:40 +0200
      Re: [PATCH 1/3] mmc: fix mmc mode selection for HS-DDR and higher Ulf Hansson <ulf.hansson@linaro.org> - 2016-06-02 17:10 +0200

csiph-web