Re: [PATCH 1/3] mmc: fix mmc mode selection for HS-DDR and higher

From	Bjorn Andersson <bjorn.andersson@linaro.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/3] mmc: fix mmc mode selection for HS-DDR and higher
Date	2016-06-01 21:10 +0200
Message-ID	<rFjGG-41O-31@gated-at.bofh.it> (permalink)
References	<rE31f-32L-3@gated-at.bofh.it> <rE31f-32L-11@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Sun, May 29, 2016 at 12:04 AM, Chen-Yu Tsai <wens@csie.org> wrote:
> When IS_ERR_VALUE was removed from the mmc core code, it was replaced
> with a simple not-zero check. This does not work, as the value checked
> is the return value for mmc_select_bus_width, which returns the set
> bit width on success. This made eMMC modes higher than HS-DDR unusable.
>
> Fix this by checking for a positive return value instead.

mmc_select_bus_width() can return 0 on "success" as well and the
previous check was !IS_ERR_VALUE(err), which coverts that. So I
believe these checks should be for err >= 0 rather than just > 0.

Either way this fixes the boot failures seen on my Qualcomm based
boards with v4.7-rc1.

Regards,
Bjorn

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH 1/3] mmc: fix mmc mode selection for HS-DDR and higher Bjorn Andersson <bjorn.andersson@linaro.org> - 2016-06-01 21:10 +0200
  Re: [PATCH 1/3] mmc: fix mmc mode selection for HS-DDR and higher Chen-Yu Tsai <wens@csie.org> - 2016-06-02 10:10 +0200

csiph-web