Re: [PATCH 1/2] lib/mpi: mpi_read_raw_data(): purge redundant clearing of nbits

From	Herbert Xu <herbert@gondor.apana.org.au>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/2] lib/mpi: mpi_read_raw_data(): purge redundant clearing of nbits
Date	2016-05-31 12:20 +0200
Message-ID	<rEOWd-1nn-1@gated-at.bofh.it> (permalink)
References	<rD1kR-5GF-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Thu, May 26, 2016 at 01:05:31PM +0200, Nicolai Stange wrote:
> In mpi_read_raw_data(), unsigned nbits is calculated as follows:
> 
>  nbits = nbytes * 8;
> 
> and redundantly cleared later on if nbytes == 0:
> 
>   if (nbytes > 0)
>     ...
>   else
>     nbits = 0;
> 
> Purge this redundant clearing for the sake of clarity.
> 
> Signed-off-by: Nicolai Stange <nicstange@gmail.com>

Both applied.
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 1/2] lib/mpi: mpi_read_raw_data(): purge redundant clearing of nbits Nicolai Stange <nicstange@gmail.com> - 2016-05-26 13:10 +0200
  [PATCH 2/2] lib/mpi: mpi_read_raw_data(): fix nbits calculation Nicolai Stange <nicstange@gmail.com> - 2016-05-26 13:10 +0200
  Re: [PATCH 1/2] lib/mpi: mpi_read_raw_data(): purge redundant  clearing of nbits Herbert Xu <herbert@gondor.apana.org.au> - 2016-05-31 12:20 +0200

csiph-web