[PATCH 1/2] lib/mpi: mpi_read_raw_data(): purge redundant clearing of nbits

From	Nicolai Stange <nicstange@gmail.com>
Newsgroups	linux.kernel
Subject	[PATCH 1/2] lib/mpi: mpi_read_raw_data(): purge redundant clearing of nbits
Date	2016-05-26 13:10 +0200
Message-ID	<rD1kR-5GF-3@gated-at.bofh.it> (permalink)
Organization	linux.* mail to news gateway

Show all headers | View raw

In mpi_read_raw_data(), unsigned nbits is calculated as follows:

 nbits = nbytes * 8;

and redundantly cleared later on if nbytes == 0:

  if (nbytes > 0)
    ...
  else
    nbits = 0;

Purge this redundant clearing for the sake of clarity.

Signed-off-by: Nicolai Stange <nicstange@gmail.com>
---
 Applicable to linux-next-20160525.

 lib/mpi/mpicoder.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/lib/mpi/mpicoder.c b/lib/mpi/mpicoder.c
index 747606f..c160393 100644
--- a/lib/mpi/mpicoder.c
+++ b/lib/mpi/mpicoder.c
@@ -51,8 +51,6 @@ MPI mpi_read_raw_data(const void *xbuffer, size_t nbytes)
 	}
 	if (nbytes > 0)
 		nbits -= count_leading_zeros(buffer[0]);
-	else
-		nbits = 0;
 
 	nlimbs = DIV_ROUND_UP(nbytes, BYTES_PER_MPI_LIMB);
 	val = mpi_alloc(nlimbs);
-- 
2.8.2

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH 1/2] lib/mpi: mpi_read_raw_data(): purge redundant clearing of nbits Nicolai Stange <nicstange@gmail.com> - 2016-05-26 13:10 +0200
  [PATCH 2/2] lib/mpi: mpi_read_raw_data(): fix nbits calculation Nicolai Stange <nicstange@gmail.com> - 2016-05-26 13:10 +0200

csiph-web