Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1408174

Re: [PATCH] pwm: don't allow duty cycle higher than period

Path csiph.com!feeder.erje.net!1.us.feeder.erje.net!newsfeed.fsmpi.rwth-aachen.de!newsfeed.straub-nv.de!news.mixmin.net!aioe.org!gothmog.csi.it!bofh.it!news.nic.it!robomod
From Brian Norris <briannorris@chromium.org>
Newsgroups linux.kernel
Subject Re: [PATCH] pwm: don't allow duty cycle higher than period
Date Fri, 27 May 2016 18:40:02 +0200
Message-ID <rDsXM-5NX-33@gated-at.bofh.it> (permalink)
References <rDaHw-2Xq-17@gated-at.bofh.it> <rDkxc-uS-15@gated-at.bofh.it> <rDsXL-5NX-27@gated-at.bofh.it> <rDsXL-5NX-25@gated-at.bofh.it>
X-Original-To Boris Brezillon <boris.brezillon@free-electrons.com>
Dkim-Signature v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=+Cds3VHl638vYqVp+3gYf41Q8E3rT0ZGGgVUJovA2Rw=; b=VTcJGdvHz8EyyxX+ew2s9gTntuhDRpBO7q1w9jndmsmq4vFMYKvyr9JzCcuYfsSFK+ M027ACp6CTKkcNYjgB45+/eT4roy8DYjcADI4Wv3LpUbwolKPmuHXzii+n2oHEiN+Pbx gliMA0ZevgZoSmJdzp2JLqHruCHSt99o7WuMU=
X-Google-Dkim-Signature v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=+Cds3VHl638vYqVp+3gYf41Q8E3rT0ZGGgVUJovA2Rw=; b=WbZT/X02rgrDY1QIj4kC0g1WPvVKujhWiELEUn+T8+O1ZYrQV3vOIO2Vz2t4n4uC2u pFOKPwLAH/loOAO7oYSZP0fFSf0npB3z/IC4gALv2RmTAHn6hA8E9wxVRRgqaZH69TvZ ScXiZLiKtsKJ9J2R1ynRxxTm7wIqFCnziGRJjRVlmRmFc7VF6hQqUv071opK8Ntd1Zzi wtn8vw00EQYr9UXuh1Mk8RC9UfIVzdC740pK12VVyGcYm40wwSVOhl2Ss3C7zWeq69bP x6tOJNx9MTynJrTwYJO0i2RF4TB0mypy/AEJbwu2K930FyPCb08+5D8rhFjbEs//5UJI 8Org==
X-Gm-Message-State ALyK8tIxJ6M+hC1wz9unxH8ytD+zLnJHUKu11HJ+4p8j9Gkq8cAtBcGomY2nT5wy0a2LYB9D
X-Received by 10.98.77.6 with SMTP id a6mr23898665pfb.133.1464367185607; Fri, 27 May 2016 09:39:45 -0700 (PDT)
MIME-Version 1.0
Content-Type text/plain; charset=us-ascii
Content-Disposition inline
User-Agent Mutt/1.5.21 (2010-09-15)
Sender robomod@news.nic.it
List-ID <linux-kernel.vger.kernel.org>
X-Mailing-List linux-kernel@vger.kernel.org
Approved robomod@news.nic.it
Lines 14
Organization linux.* mail to news gateway
X-Original-Cc Thierry Reding <thierry.reding@gmail.com>, linux-pwm@vger.kernel.org, linux-kernel@vger.kernel.org, Brian Norris <computersforpeace@gmail.com>, Doug Anderson <dianders@chromium.org>
X-Original-Date Fri, 27 May 2016 09:39:43 -0700
X-Original-Message-ID <20160527163943.GB80118@google.com>
X-Original-References <1464296730-121773-1-git-send-email-briannorris@chromium.org> <20160527093439.5ad237c5@bbrezillon> <20160527163533.GA80118@google.com> <20160527183814.6f8f4ba7@bbrezillon>
X-Original-Sender linux-kernel-owner@vger.kernel.org
Xref csiph.com linux.kernel:1408174

Show key headers only | View raw


On Fri, May 27, 2016 at 06:38:14PM +0200, Boris Brezillon wrote:
> On Fri, 27 May 2016 09:35:33 -0700
> Brian Norris <briannorris@chromium.org> wrote:
> > On Fri, May 27, 2016 at 09:34:39AM +0200, Boris Brezillon wrote:
> > Now that you mention it, I think you've also dropped some signed
> > (negative value) checking in pwm_config(). I'll squash in your diff +
> > some pwm_config() fixes.
> 
> ->period and ->duty_cycle are unsigned now ;).

Not in pwm_config(). And we don't want to implitly make thos into large
unsigned values.

Brian

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH] pwm: don't allow duty cycle higher than period Brian Norris <briannorris@chromium.org> - 2016-05-26 23:10 +0200
  Re: [PATCH] pwm: don't allow duty cycle higher than period Boris Brezillon <boris.brezillon@free-electrons.com> - 2016-05-27 09:40 +0200
    Re: [PATCH] pwm: don't allow duty cycle higher than period Brian Norris <briannorris@chromium.org> - 2016-05-27 18:40 +0200
      Re: [PATCH] pwm: don't allow duty cycle higher than period Brian Norris <briannorris@chromium.org> - 2016-05-27 19:00 +0200
    Re: [PATCH] pwm: don't allow duty cycle higher than period Brian Norris <briannorris@chromium.org> - 2016-05-27 18:40 +0200
      Re: [PATCH] pwm: don't allow duty cycle higher than period Boris Brezillon <boris.brezillon@free-electrons.com> - 2016-05-27 18:40 +0200
        Re: [PATCH] pwm: don't allow duty cycle higher than period Boris Brezillon <boris.brezillon@free-electrons.com> - 2016-05-27 18:50 +0200

csiph-web