Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1407502
| From | Felipe Balbi <balbi@kernel.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH] dwc3: gadget: Introduce dwc3_endpoint_xfer_xxx() to check endpoint type |
| Date | 2016-05-26 12:30 +0200 |
| Message-ID | <rD0Ia-5eg-29@gated-at.bofh.it> (permalink) |
| References | (2 earlier) <rCXKh-3nN-3@gated-at.bofh.it> <rCYn5-3DH-27@gated-at.bofh.it> <rCYQ2-42k-19@gated-at.bofh.it> <rD05r-4IP-27@gated-at.bofh.it> <rD0Ia-5eg-17@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
[Multipart message — attachments visible in raw view] - view raw
Hi, Baolin Wang <baolin.wang@linaro.org> writes: > On 26 May 2016 at 17:45, Felipe Balbi <balbi@kernel.org> wrote: >> >> Hi, >> >> Baolin Wang <baolin.wang@linaro.org> writes: >> >> <trim> >> >>>> Also note that the usb_endpoint_xfer_isoc() call on line 2067 of >>>> gadget.c (as in my testing/next from today) won't even get executed, so >>>> we're safe there. >>> >>> Never will be executed? then we can remove the >>> usb_endpoint_xfer_isoc() (line 2025) at risk? >>> >>> 2023 clean_busy = dwc3_cleanup_done_reqs(dwc, dep, event, status); >>> 2024 if (clean_busy && (is_xfer_complete || >>> 2025 >>> usb_endpoint_xfer_isoc(dep->endpoint.desc))) >>> 2026 dep->flags &= ~DWC3_EP_BUSY; >> >> hmm, now that I look at this again, in case of XferInProgress, we could >> still have a problem. >> >> I'll fix it up in that commit I pointed you to. > > Great. Thanks. fixed now: https://git.kernel.org/cgit/linux/kernel/git/balbi/usb.git/commit/?h=testing/next&id=983b84268656ff2686253b05097d28003bbec52f -- balbi
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH] dwc3: gadget: Introduce dwc3_endpoint_xfer_xxx() to check endpoint type Baolin Wang <baolin.wang@linaro.org> - 2016-05-26 07:00 +0200
Re: [PATCH] dwc3: gadget: Introduce dwc3_endpoint_xfer_xxx() to check endpoint type Felipe Balbi <balbi@kernel.org> - 2016-05-26 08:30 +0200
Re: [PATCH] dwc3: gadget: Introduce dwc3_endpoint_xfer_xxx() to check endpoint type Baolin Wang <baolin.wang@linaro.org> - 2016-05-26 09:20 +0200
Re: [PATCH] dwc3: gadget: Introduce dwc3_endpoint_xfer_xxx() to check endpoint type Felipe Balbi <balbi@kernel.org> - 2016-05-26 10:00 +0200
Re: [PATCH] dwc3: gadget: Introduce dwc3_endpoint_xfer_xxx() to check endpoint type Baolin Wang <baolin.wang@linaro.org> - 2016-05-26 10:30 +0200
Re: [PATCH] dwc3: gadget: Introduce dwc3_endpoint_xfer_xxx() to check endpoint type Felipe Balbi <balbi@kernel.org> - 2016-05-26 11:50 +0200
Re: [PATCH] dwc3: gadget: Introduce dwc3_endpoint_xfer_xxx() to check endpoint type Felipe Balbi <balbi@kernel.org> - 2016-05-26 12:30 +0200
Re: [PATCH] dwc3: gadget: Introduce dwc3_endpoint_xfer_xxx() to check endpoint type Baolin Wang <baolin.wang@linaro.org> - 2016-05-26 12:40 +0200
Re: [PATCH] dwc3: gadget: Introduce dwc3_endpoint_xfer_xxx() to check endpoint type Baolin Wang <baolin.wang@linaro.org> - 2016-05-26 12:30 +0200
csiph-web