Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1407399

Re: [PATCH] dwc3: gadget: Introduce dwc3_endpoint_xfer_xxx() to check endpoint type

From Felipe Balbi <balbi@kernel.org>
Newsgroups linux.kernel
Subject Re: [PATCH] dwc3: gadget: Introduce dwc3_endpoint_xfer_xxx() to check endpoint type
Date 2016-05-26 08:30 +0200
Message-ID <rCWXT-2Qp-13@gated-at.bofh.it> (permalink)
References <rCVyO-1Pn-5@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

Hi,

Baolin Wang <baolin.wang@linaro.org> writes:
> When handling the endpoint interrupt handler, it maybe disable the endpoint
> from another core user to set the USB endpoint descriptor pointor to be NULL
> while issuing usb_gadget_giveback_request() function to release lock. So it
> will be one bug to check the endpoint type by usb_endpoint_xfer_xxx() APIs with
> one NULL USB endpoint descriptor.

too complex, Baolin :-) Can you see if this helps:

https://git.kernel.org/cgit/linux/kernel/git/balbi/usb.git/commit/?id=88bf752cfb55e57a78e27c931c9fef63240c739a

The only situation when that can happen is while we drop our lock on
dwc3_gadget_giveback().

-- 
balbi

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] dwc3: gadget: Introduce dwc3_endpoint_xfer_xxx() to check endpoint type Baolin Wang <baolin.wang@linaro.org> - 2016-05-26 07:00 +0200
  Re: [PATCH] dwc3: gadget: Introduce dwc3_endpoint_xfer_xxx() to check endpoint type Felipe Balbi <balbi@kernel.org> - 2016-05-26 08:30 +0200
    Re: [PATCH] dwc3: gadget: Introduce dwc3_endpoint_xfer_xxx() to check  endpoint type Baolin Wang <baolin.wang@linaro.org> - 2016-05-26 09:20 +0200
      Re: [PATCH] dwc3: gadget: Introduce dwc3_endpoint_xfer_xxx() to check endpoint type Felipe Balbi <balbi@kernel.org> - 2016-05-26 10:00 +0200
        Re: [PATCH] dwc3: gadget: Introduce dwc3_endpoint_xfer_xxx() to check  endpoint type Baolin Wang <baolin.wang@linaro.org> - 2016-05-26 10:30 +0200
          Re: [PATCH] dwc3: gadget: Introduce dwc3_endpoint_xfer_xxx() to check endpoint type Felipe Balbi <balbi@kernel.org> - 2016-05-26 11:50 +0200
            Re: [PATCH] dwc3: gadget: Introduce dwc3_endpoint_xfer_xxx() to check endpoint type Felipe Balbi <balbi@kernel.org> - 2016-05-26 12:30 +0200
              Re: [PATCH] dwc3: gadget: Introduce dwc3_endpoint_xfer_xxx() to check  endpoint type Baolin Wang <baolin.wang@linaro.org> - 2016-05-26 12:40 +0200
            Re: [PATCH] dwc3: gadget: Introduce dwc3_endpoint_xfer_xxx() to check  endpoint type Baolin Wang <baolin.wang@linaro.org> - 2016-05-26 12:30 +0200

csiph-web