Re: [PATCH] mm: oom: do not reap task if there are live threads in threadgroup

From	Vladimir Davydov <vdavydov@virtuozzo.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] mm: oom: do not reap task if there are live threads in threadgroup
Date	2016-05-24 14:30 +0200
Message-ID	<rCjDc-3cK-15@gated-at.bofh.it> (permalink)
References	<rCinL-2ur-17@gated-at.bofh.it> <rCj0u-2KE-13@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Tue, May 24, 2016 at 01:46:12PM +0200, Michal Hocko wrote:
> On Tue 24-05-16 14:00:28, Vladimir Davydov wrote:
> > If the current process is exiting, we don't invoke oom killer, instead
> > we give it access to memory reserves and try to reap its mm in case
> > nobody is going to use it. There's a mistake in the code performing this
> > check - we just ignore any process of the same thread group no matter if
> > it is exiting or not - see try_oom_reaper. Fix it.
> 
> This is not a problem with the current code because of 98748bd72200
> ("oom: consider multi-threaded tasks in task_will_free_mem") which got
> merged later on, however.

True, I missed that patch.

> 
> The check is not needed so we can indeed drop it.
> 
> Fixes: 3ef22dfff239 ("oom, oom_reaper: try to reap tasks which skip
> regular OOM killer path")
> 
> Just in case somebody wants to backport only 3ef22dfff239.
> 
> > Signed-off-by: Vladimir Davydov <vdavydov@virtuozzo.com>
> 
> Acked-by: Michal Hocko <mhocko@suse.com>

Thanks.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] mm: oom: do not reap task if there are live threads in threadgroup Vladimir Davydov <vdavydov@virtuozzo.com> - 2016-05-24 13:10 +0200
  Re: [PATCH] mm: oom: do not reap task if there are live threads in  threadgroup Michal Hocko <mhocko@kernel.org> - 2016-05-24 13:50 +0200
    Re: [PATCH] mm: oom: do not reap task if there are live threads in  threadgroup Vladimir Davydov <vdavydov@virtuozzo.com> - 2016-05-24 14:30 +0200

csiph-web