[PATCH] mm: oom: do not reap task if there are live threads in threadgroup

From	Vladimir Davydov <vdavydov@virtuozzo.com>
Newsgroups	linux.kernel
Subject	[PATCH] mm: oom: do not reap task if there are live threads in threadgroup
Date	2016-05-24 13:10 +0200
Message-ID	<rCinL-2ur-17@gated-at.bofh.it> (permalink)
Organization	linux.* mail to news gateway

Show all headers | View raw

If the current process is exiting, we don't invoke oom killer, instead
we give it access to memory reserves and try to reap its mm in case
nobody is going to use it. There's a mistake in the code performing this
check - we just ignore any process of the same thread group no matter if
it is exiting or not - see try_oom_reaper. Fix it.

Signed-off-by: Vladimir Davydov <vdavydov@virtuozzo.com>
---
 mm/oom_kill.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/mm/oom_kill.c b/mm/oom_kill.c
index c0e37dd1422f..03bf7a472296 100644
--- a/mm/oom_kill.c
+++ b/mm/oom_kill.c
@@ -618,8 +618,6 @@ void try_oom_reaper(struct task_struct *tsk)
 
 			if (!process_shares_mm(p, mm))
 				continue;
-			if (same_thread_group(p, tsk))
-				continue;
 			if (fatal_signal_pending(p))
 				continue;
 
-- 
2.1.4

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH] mm: oom: do not reap task if there are live threads in threadgroup Vladimir Davydov <vdavydov@virtuozzo.com> - 2016-05-24 13:10 +0200
  Re: [PATCH] mm: oom: do not reap task if there are live threads in  threadgroup Michal Hocko <mhocko@kernel.org> - 2016-05-24 13:50 +0200
    Re: [PATCH] mm: oom: do not reap task if there are live threads in  threadgroup Vladimir Davydov <vdavydov@virtuozzo.com> - 2016-05-24 14:30 +0200

csiph-web