Re: [PATCH V5 5/6] vfio: platform: call _RST method when using ACPI

From	Sinan Kaya <okaya@codeaurora.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH V5 5/6] vfio: platform: call _RST method when using ACPI
Date	2016-05-24 04:30 +0200
Message-ID	<rCagy-5zr-9@gated-at.bofh.it> (permalink)
References	<rzgiv-HG-67@gated-at.bofh.it> <rzgiE-HG-303@gated-at.bofh.it> <rBZXQ-7DR-9@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 5/23/2016 11:21 AM, Eric Auger wrote:
>> +	acpi_ret = acpi_evaluate_integer(handle, "_RST", NULL, &val);
>> > +	if (ACPI_FAILURE(acpi_ret))
>> > +		return -EINVAL;
> Can't you return something more explicit here? The error code will be
> visible to the userspace. Difficult for him to understand the cause of
> the failure in that case.

I can also add a reset failed message to both DT and ACPI reset calls.

Will that work?

-- 
Sinan Kaya
Qualcomm Technologies, Inc. on behalf of Qualcomm Innovation Center, Inc.
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH V5 5/6] vfio: platform: call _RST method when using ACPI Sinan Kaya <okaya@codeaurora.org> - 2016-05-16 04:20 +0200
  Re: [PATCH V5 5/6] vfio: platform: call _RST method when using ACPI Eric Auger <eric.auger@linaro.org> - 2016-05-23 16:50 +0200
    Re: [PATCH V5 5/6] vfio: platform: call _RST method when using ACPI Sinan Kaya <okaya@codeaurora.org> - 2016-05-24 04:30 +0200
  Re: [PATCH V5 5/6] vfio: platform: call _RST method when using ACPI Eric Auger <eric.auger@linaro.org> - 2016-05-23 17:30 +0200
    Re: [PATCH V5 5/6] vfio: platform: call _RST method when using ACPI Sinan Kaya <okaya@codeaurora.org> - 2016-05-24 04:30 +0200

csiph-web