Re: [PATCH 2/5] drm: mediatek: add CONFIG_OF dependency

From	Matthias Brugger <matthias.bgg@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 2/5] drm: mediatek: add CONFIG_OF dependency
Date	2016-05-19 17:00 +0200
Message-ID	<rAxAC-16l-19@gated-at.bofh.it> (permalink)
References	<rAccN-4lF-1@gated-at.bofh.it> <rAcmu-4oQ-15@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw


On 18/05/16 18:07, Arnd Bergmann wrote:
> The mediatek DRM driver can be configured for compile testing with
> CONFIG_OF disabled, but then fails to link:
>
> drivers/gpu/built-in.o: In function `mtk_drm_bind':
> analogix_dp_reg.c:(.text+0x52888): undefined reference to `of_find_device_by_node'
> analogix_dp_reg.c:(.text+0x52930): undefined reference to `of_find_device_by_node'
>
> This adds an explicit Kconfig dependency.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
>   drivers/gpu/drm/mediatek/Kconfig | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/mediatek/Kconfig b/drivers/gpu/drm/mediatek/Kconfig
> index 545973f6b743..67183e26971d 100644
> --- a/drivers/gpu/drm/mediatek/Kconfig
> +++ b/drivers/gpu/drm/mediatek/Kconfig
> @@ -3,6 +3,7 @@ config DRM_MEDIATEK
>   	depends on DRM
>   	depends on ARCH_MEDIATEK || (ARM && COMPILE_TEST)
>   	depends on COMMON_CLK
> +	depends on OF
>   	select DRM_GEM_CMA_HELPER
>   	select DRM_KMS_HELPER
>   	select DRM_MIPI_DSI
>

Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com>

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 0/5] drm: fixes for merge-window regressions Arnd Bergmann <arnd@arndb.de> - 2016-05-18 18:10 +0200
  [PATCH 1/5] headers_check: don't warn about c++ guards Arnd Bergmann <arnd@arndb.de> - 2016-05-18 18:10 +0200
    Re: [PATCH 1/5] headers_check: don't warn about c++ guards Emil Velikov <emil.l.velikov@gmail.com> - 2016-05-18 22:30 +0200
  [PATCH 4/5] drm: exynos: mark pm functions as __maybe_unused Arnd Bergmann <arnd@arndb.de> - 2016-05-18 18:10 +0200
  [PATCH 3/5] drm: mediatek: fixup drm_gem_object_lookup API change Arnd Bergmann <arnd@arndb.de> - 2016-05-18 18:10 +0200
    Re: [PATCH 3/5] drm: mediatek: fixup drm_gem_object_lookup API change Matthias Brugger <matthias.bgg@gmail.com> - 2016-05-19 17:00 +0200
  [PATCH 5/5] drm: remove unused dev variables Arnd Bergmann <arnd@arndb.de> - 2016-05-18 18:10 +0200
    Re: [PATCH 5/5] drm: remove unused dev variables Daniel Vetter <daniel@ffwll.ch> - 2016-05-18 19:20 +0200
  [PATCH 2/5] drm: mediatek: add CONFIG_OF dependency Arnd Bergmann <arnd@arndb.de> - 2016-05-18 18:20 +0200
    Re: [PATCH 2/5] drm: mediatek: add CONFIG_OF dependency Matthias Brugger <matthias.bgg@gmail.com> - 2016-05-19 17:00 +0200

csiph-web