Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1403116

[PATCH 1/5] headers_check: don't warn about c++ guards

Show all headers | View raw

A recent addition to the DRM tree for 4.7 added 'extern "C"' guards
for c++ to all the DRM headers, and that now causes warnings
in 'make headers_check':

usr/include/drm/amdgpu_drm.h:38: userspace cannot reference function or variable defined in the kernel
usr/include/drm/drm.h:63: userspace cannot reference function or variable defined in the kernel
usr/include/drm/drm.h:699: userspace cannot reference function or variable defined in the kernel
usr/include/drm/drm_fourcc.h:30: userspace cannot reference function or variable defined in the kernel
usr/include/drm/drm_mode.h:33: userspace cannot reference function or variable defined in the kernel
usr/include/drm/drm_sarea.h:38: userspace cannot reference function or variable defined in the kernel
usr/include/drm/exynos_drm.h:21: userspace cannot reference function or variable defined in the kernel
usr/include/drm/i810_drm.h:7: userspace cannot reference function or variable defined in the kernel

This changes the headers_check.pl script to not warn about this.
I'm listing the merge commit as introducing the problem, because
there are several patches in this branch that each do this for
one file.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Fixes: 7c10ddf87472 ("Merge branch 'drm-uapi-extern-c-fixes' of https://github.com/evelikov/linux into drm-next")
---
 scripts/headers_check.pl | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/scripts/headers_check.pl b/scripts/headers_check.pl
index 62320f93e903..8b2da054cdc3 100755
--- a/scripts/headers_check.pl
+++ b/scripts/headers_check.pl
@@ -69,6 +69,10 @@ sub check_declarations
 	if ($line =~ m/^void seqbuf_dump\(void\);/) {
 		return;
 	}
+	# drm headers are being C++ friendly
+	if ($line =~ m/^extern "C"/) {
+		return;
+	}
 	if ($line =~ m/^(\s*extern|unsigned|char|short|int|long|void)\b/) {
 		printf STDERR "$filename:$lineno: " .
 			      "userspace cannot reference function or " .
-- 
2.7.0

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/5] drm: fixes for merge-window regressions Arnd Bergmann <arnd@arndb.de> - 2016-05-18 18:10 +0200
  [PATCH 1/5] headers_check: don't warn about c++ guards Arnd Bergmann <arnd@arndb.de> - 2016-05-18 18:10 +0200
    Re: [PATCH 1/5] headers_check: don't warn about c++ guards Emil Velikov <emil.l.velikov@gmail.com> - 2016-05-18 22:30 +0200
  [PATCH 4/5] drm: exynos: mark pm functions as __maybe_unused Arnd Bergmann <arnd@arndb.de> - 2016-05-18 18:10 +0200
  [PATCH 3/5] drm: mediatek: fixup drm_gem_object_lookup API change Arnd Bergmann <arnd@arndb.de> - 2016-05-18 18:10 +0200
    Re: [PATCH 3/5] drm: mediatek: fixup drm_gem_object_lookup API change Matthias Brugger <matthias.bgg@gmail.com> - 2016-05-19 17:00 +0200
  [PATCH 5/5] drm: remove unused dev variables Arnd Bergmann <arnd@arndb.de> - 2016-05-18 18:10 +0200
    Re: [PATCH 5/5] drm: remove unused dev variables Daniel Vetter <daniel@ffwll.ch> - 2016-05-18 19:20 +0200
  [PATCH 2/5] drm: mediatek: add CONFIG_OF dependency Arnd Bergmann <arnd@arndb.de> - 2016-05-18 18:20 +0200
    Re: [PATCH 2/5] drm: mediatek: add CONFIG_OF dependency Matthias Brugger <matthias.bgg@gmail.com> - 2016-05-19 17:00 +0200

csiph-web