Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1403469

Re: [PATCH 1/1 RFC] net/phy: Add Lantiq PHY driver

Show all headers | View raw

On Wednesday 18 May 2016 19:01:09, Andrew Lunn wrote:
> > For LEDs, we had a patch series floating around adding LED triggers [1],
> > and it seems to me like the LEDs class subsystem would be a good fit for
> > controlling PHY LEDs, possibly with the help of PHYLIB when it comes to
> > doing the low-level work of registering LEDs and their names with the
> > LEDS subsystem.
> > 
> > [1]: http://lists.openwall.net/netdev/2016/03/23/61
> 
> That patch fizzled out. I got the feeling it was pushing the
> capabilities of the coder. I do however think it is a reasonable path
> to follow for PHY LEDs.
> 
> I took a quick look at the datasheet and the controlling of the LEDs
> is very flexible. It should not be a problem to expose some of that
> functionality via LED triggers.

To be honest I don't know how the PHY LEDs could be set by LED triggers. 
Wouldn't that require to create triggers for each value which can be written 
to LEDxH and LEDxL? In my case the hardware requires some specific setting due 
to LED connections.
Of course making the LED configuration changeable at runtime would be awesome.

Best regards,
Alexander

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 1/1 RFC] net/phy: Add Lantiq PHY driver Alexander Stein <alexander.stein@systec-electronic.com> - 2016-05-18 18:10 +0200
  Re: [PATCH 1/1 RFC] net/phy: Add Lantiq PHY driver Florian Fainelli <f.fainelli@gmail.com> - 2016-05-18 18:30 +0200
    Re: [PATCH 1/1 RFC] net/phy: Add Lantiq PHY driver Andrew Lunn <andrew@lunn.ch> - 2016-05-18 19:10 +0200
      Re: [PATCH 1/1 RFC] net/phy: Add Lantiq PHY driver Alexander Stein <alexander.stein@systec-electronic.com> - 2016-05-19 09:10 +0200
        Re: [PATCH 1/1 RFC] net/phy: Add Lantiq PHY driver Andrew Lunn <andrew@lunn.ch> - 2016-05-19 14:20 +0200
    Re: [PATCH 1/1 RFC] net/phy: Add Lantiq PHY driver John Crispin <john@phrozen.org> - 2016-05-19 07:00 +0200
      Re: [PATCH 1/1 RFC] net/phy: Add Lantiq PHY driver Alexander Stein <alexander.stein@systec-electronic.com> - 2016-05-19 09:00 +0200
        Re: [PATCH 1/1 RFC] net/phy: Add Lantiq PHY driver John Crispin <john@phrozen.org> - 2016-05-19 09:10 +0200
          Re: [PATCH 1/1 RFC] net/phy: Add Lantiq PHY driver Alexander Stein <alexander.stein@systec-electronic.com> - 2016-05-19 09:30 +0200
          Re: [PATCH 1/1 RFC] net/phy: Add Lantiq PHY driver Mathias Kresin <openwrt@kresin.me> - 2016-05-19 12:10 +0200
            Re: [PATCH 1/1 RFC] net/phy: Add Lantiq PHY driver Alexander Stein <alexander.stein@systec-electronic.com> - 2016-05-19 12:30 +0200
              RE: [PATCH 1/1 RFC] net/phy: Add Lantiq PHY driver "Mehrtens, Hauke" <hauke.mehrtens@intel.com> - 2016-05-23 11:20 +0200
                Re: [PATCH 1/1 RFC] net/phy: Add Lantiq PHY driver Alexander Stein <alexander.stein@systec-electronic.com> - 2016-05-23 12:00 +0200
                Re: [PATCH 1/1 RFC] net/phy: Add Lantiq PHY driver Mathias Kresin <openwrt@kresin.me> - 2016-05-23 12:10 +0200

csiph-web