Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1403466

Re: [PATCH 1/1 RFC] net/phy: Add Lantiq PHY driver

From Alexander Stein <alexander.stein@systec-electronic.com>
Newsgroups linux.kernel
Subject Re: [PATCH 1/1 RFC] net/phy: Add Lantiq PHY driver
Date 2016-05-19 09:00 +0200
Message-ID <rAq66-4HY-3@gated-at.bofh.it> (permalink)
References <rAccO-4lF-15@gated-at.bofh.it> <rAcw9-4sK-3@gated-at.bofh.it> <rAodX-3xB-7@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

Hi John,

On Thursday 19 May 2016 06:50:56, John Crispin wrote:
> On 18/05/2016 18:24, Florian Fainelli wrote:
> > CC'ing Andrew, John,
> 
> also CC'ing Matthias and Hauke. we have had a driver in OpenWrt/LEDE for
> several years that seems a little more complete than this one.
> 
> https://git.lede-project.org/?p=source.git;a=blob;f=target/linux/lantiq/patc
> hes-4.4/0023-NET-PHY-adds-driver-for-lantiq-PHY11G.patch;h=93bb4275ec1d261f3
> 98afb8fdc879c1dd973f997;hb=HEAD

Thanks for the link, I wasn't aware of that patch. I like it in general, but 
there are some things I'd like to get addressed first:
* vr9_gphy_of_reg_init() writes uncoditionally to led3h and led3l even on
  PEf7071 which does not have this register at all
* Why is PHY_HAS_INTERRUPT commented out everywhere?
* ltq_phy_init and ltq_phy_exit can be simplified using phy_drivers_register
  and phy_drivers_unregister
* A mdio_device_id table is missing

Best regards,
Alexander

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 1/1 RFC] net/phy: Add Lantiq PHY driver Alexander Stein <alexander.stein@systec-electronic.com> - 2016-05-18 18:10 +0200
  Re: [PATCH 1/1 RFC] net/phy: Add Lantiq PHY driver Florian Fainelli <f.fainelli@gmail.com> - 2016-05-18 18:30 +0200
    Re: [PATCH 1/1 RFC] net/phy: Add Lantiq PHY driver Andrew Lunn <andrew@lunn.ch> - 2016-05-18 19:10 +0200
      Re: [PATCH 1/1 RFC] net/phy: Add Lantiq PHY driver Alexander Stein <alexander.stein@systec-electronic.com> - 2016-05-19 09:10 +0200
        Re: [PATCH 1/1 RFC] net/phy: Add Lantiq PHY driver Andrew Lunn <andrew@lunn.ch> - 2016-05-19 14:20 +0200
    Re: [PATCH 1/1 RFC] net/phy: Add Lantiq PHY driver John Crispin <john@phrozen.org> - 2016-05-19 07:00 +0200
      Re: [PATCH 1/1 RFC] net/phy: Add Lantiq PHY driver Alexander Stein <alexander.stein@systec-electronic.com> - 2016-05-19 09:00 +0200
        Re: [PATCH 1/1 RFC] net/phy: Add Lantiq PHY driver John Crispin <john@phrozen.org> - 2016-05-19 09:10 +0200
          Re: [PATCH 1/1 RFC] net/phy: Add Lantiq PHY driver Alexander Stein <alexander.stein@systec-electronic.com> - 2016-05-19 09:30 +0200
          Re: [PATCH 1/1 RFC] net/phy: Add Lantiq PHY driver Mathias Kresin <openwrt@kresin.me> - 2016-05-19 12:10 +0200
            Re: [PATCH 1/1 RFC] net/phy: Add Lantiq PHY driver Alexander Stein <alexander.stein@systec-electronic.com> - 2016-05-19 12:30 +0200
              RE: [PATCH 1/1 RFC] net/phy: Add Lantiq PHY driver "Mehrtens, Hauke" <hauke.mehrtens@intel.com> - 2016-05-23 11:20 +0200
                Re: [PATCH 1/1 RFC] net/phy: Add Lantiq PHY driver Alexander Stein <alexander.stein@systec-electronic.com> - 2016-05-23 12:00 +0200
                Re: [PATCH 1/1 RFC] net/phy: Add Lantiq PHY driver Mathias Kresin <openwrt@kresin.me> - 2016-05-23 12:10 +0200

csiph-web