Re: [PATCH] signal: move the "sig < SIGRTMIN" check into siginmask(sig)

From	Meelis Roos <mroos@linux.ee>
Newsgroups	linux.kernel
Subject	Re: [PATCH] signal: move the "sig < SIGRTMIN" check into siginmask(sig)
Date	2016-05-18 19:10 +0200
Message-ID	<rAd8S-4Ww-19@gated-at.bofh.it> (permalink)
References	<rzTjQ-pn-13@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

> All the users of siginmask() must ensure that sig < SIGRTMIN. sig_fatal()
> doesn't and this is wrong:
> 
> 	[  211.406327] UBSAN: Undefined behaviour in kernel/signal.c:911:6
> 	[  211.406365] shift exponent 32 is too large for 32-bit type 'long unsigned int'
> 
> the patch doesn't add the neccesary check to sig_fatal(), it moves the
> check into siginmask() and updates other callers.
> 
> Reported-by: Meelis Roos <mroos@linux.ee>
> Signed-off-by: Oleg Nesterov <oleg@redhat.com>

Tested on the same AthlonMP, on HP Proliant DL360G3 and PowerMac G4, 
successfully - system still works, warnings are gone.

-- 
Meelis Roos (mroos@linux.ee)

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] signal: move the "sig < SIGRTMIN" check into siginmask(sig) Oleg Nesterov <oleg@redhat.com> - 2016-05-17 22:00 +0200
  Re: [PATCH] signal: move the "sig < SIGRTMIN" check into  siginmask(sig) Meelis Roos <mroos@linux.ee> - 2016-05-18 19:10 +0200

csiph-web